fix(misc): fix moving a project into a subfolder

[leosvelperez]

Current Behavior

The move generator doesn't work correctly when moving a project to a new destination that's a subfolder of its current root path. This happens because the project configuration is created in the new destination before moving the rest of the files. Because of that, when moving the files, it collects the new project configuration as a child and moves it to another nested level, which is wrong.

Expected Behavior

The move generator should work correctly when moving a project to a new destination that's a subfolder of its current root path.

Related Issue(s)

Fixes #13910

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
nx-dev	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Feb 15, 2023 at 9:51AM (UTC)

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 06c141e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 8 targets

• nx run-many -t e2e-macos --parallel=1 --exclude=e2e-detox
• nx affected --target=e2e --base=ba19dc00ac7dc10f839e3b1c69466c3064c96c96 --head=06c141e0cbd18d91ee6e880e859dbe073d04b61d --exclude=e2e-storybook,e2e-storybook-angular --parallel=1
• nx affected --target=test --base=ba19dc00ac7dc10f839e3b1c69466c3064c96c96 --head=06c141e0cbd18d91ee6e880e859dbe073d04b61d --parallel=1
• nx affected --target=build --base=ba19dc00ac7dc10f839e3b1c69466c3064c96c96 --head=06c141e0cbd18d91ee6e880e859dbe073d04b61d --parallel=3
• nx affected --target=lint --base=ba19dc00ac7dc10f839e3b1c69466c3064c96c96 --head=06c141e0cbd18d91ee6e880e859dbe073d04b61d --parallel=3
• nx run-many -t root-lint check-imports check-commit check-lock-files depcheck --parallel=1 --no-dte
• nx-cloud record -- nx format:check --base=ba19dc00ac7dc10f839e3b1c69466c3064c96c96 --head=06c141e0cbd18d91ee6e880e859dbe073d04b61d
• nx documentation --no-dte

---

Sent with 💌 from NxCloud.

[DmitryEfimenko]

Since this PR is merged, I assume this fix should have made it at least into the latest beta.

I got @nrwl/workspace@15.8.0-beta.7 and tried moving a project into a subfolder. Got an error:

Cannot read properties of null (reading 'replace')

To reproduce:

1. clone this repo
2. run npm install @nrwl/workspace@15.8.0-beta.7
3. run: nx g @nrwl/workspace:move --project ng-superclass --destination ./ng-superclass/package --dry-run

[leosvelperez]

hey @DmitryEfimenko!

A couple of things based on your reproduction steps:

• Based on what you mention, it would look like you're manually updating only the @nrwl/workspace package version. That's not correct. All @nrwl/* and nx packages versions should be aligned. Also, it's strongly recommended to update them by running migrations nx migrate next.
• It looks like you're moving an Angular library (the name starts with ng-). If so, you must use the @nrwl/angular:move generator instead.

Please note the above points are solely based on the steps description. I can't access the repo you linked (is it private?). So, I was not able to reproduce the issue.

If the above points are irrelevant or don't solve the issue, could you open an issue with those details and an accessible repro? The error is different than what this PR addressed. It could still be an issue caused by this PR or a follow up change, but better to create a proper issue and track it separately.

[DmitryEfimenko]

@leosvelperez My bad, I specified the wrong repo link. Fixed it.

I also tried your suggestions and still got an error. It looks like it's only for angular projects. Created a issue here

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.