-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): local plugins should work under yarn workspaces #14995
fix(core): local plugins should work under yarn workspaces #14995
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
packages/nx/src/config/workspaces.ts
Outdated
@@ -313,7 +317,11 @@ export class Workspaces { | |||
const [implementationModulePath, implementationExportName] = | |||
implementation.split('#'); | |||
return () => { | |||
const module = require(path.join(directory, implementationModulePath)); | |||
const modulePath = path.join(directory, implementationModulePath); | |||
if (!statSync(modulePath + '.js') && statSync(join(modulePath + '.ts'))) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
handle when the implementationPath
has an extension.
Use extname
6ad729b
to
4cec9ce
Compare
(cherry picked from commit d7c8e03)
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
Typescript Nx plugins fail to load
Expected Behavior
Typescript Nx plugins load
Related Issue(s)
Fixes #9823