fix(core): local plugins should work under yarn workspaces #14995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
FrozenPandaz
requested changes
Feb 14, 2023
packages/nx/src/config/workspaces.ts
Outdated
| @@ -313,7 +317,11 @@ export class Workspaces { | |||
| const [implementationModulePath, implementationExportName] = | |||
| implementation.split('#'); | |||
| return () => { | |||
| const module = require(path.join(directory, implementationModulePath)); | |||
| const modulePath = path.join(directory, implementationModulePath); | |||
| if (!statSync(modulePath + '.js') && statSync(join(modulePath + '.ts'))) { | |||
There was a problem hiding this comment.
handle when the implementationPath has an extension.
Use extname
AgentEnder
force-pushed
the
fix/local-plugin-workspaces
branch
from
6ad729b
to
4cec9ce
Compare
FrozenPandaz
approved these changes
Feb 14, 2023
FrozenPandaz
pushed a commit
that referenced
this pull request
Feb 15, 2023
(cherry picked from commit d7c8e03)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Typescript Nx plugins fail to load
Expected Behavior
Typescript Nx plugins load
Related Issue(s)
Fixes #9823