fix(js): refactor ensurePackage #15074

FrozenPandaz · 2023-02-16T22:04:05Z

Current Behavior

ensurePackage does not work with pnpm as the files that are currently executing may get moved entirely.

ensurePackage does more of its fair share:

Installs the package into the workspace
Allows requiring later on
Doesn't update the Tree with the updated package.json yet appears after the generate command.

Expected Behavior

ensurePackage will work with pnpm.

Installs the package into a tmp directory
Allows requiring later on
Will not accept a Tree anymore
Will not update the Tree. That should be done via addDependenciesToPackageJson

Breaking Changes

ensurePackage will no longer install directly into the workspace. This must be done via the normal tools.

Related Issue(s)

Fixes #14933

vercel · 2023-02-16T22:04:09Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
nx-dev	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Feb 22, 2023 at 10:55PM (UTC)

nx-cloud · 2023-02-16T22:15:48Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 32c9de0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 8 targets

Sent with 💌 from NxCloud.

packages/devkit/src/utils/package-json.ts

packages/nx/src/utils/nx-plugin.ts

nartc

LGTM on nrwl/js side

packages/angular/src/generators/change-storybook-targets/change-storybook-targets.ts

packages/angular/src/generators/init/angular-v14/init.ts

packages/angular/src/generators/init/init.ts

packages/angular/src/generators/init/angular-v14/init.ts

packages/angular/src/generators/init/init.ts

barbados-clemens

Looks good from jest/cypress side

Stale

meeroslav

Linter part looks good!

barbados-clemens

cypress/jest look fine. just had a non-blocking question on if jest/cypress really need to call the jsInitGenerator.

barbados-clemens · 2023-02-22T13:59:34Z

packages/jest/src/generators/init/init.ts

+    await jsInitGenerator(tree, {
+      ...schema,
+      skipFormat: true,
+    })


I know this is just moving this around, but I was thinking about this and does @nrwl/jest really need to have the jsInitGenerator? Jest doesn't really care to have the root tsconfig just needs it's configurations? just a thought.

Okay, we can investigate removing it.

I think jest needs it for tsconfig.spec.json?

barbados-clemens · 2023-02-22T14:00:56Z

packages/cypress/src/generators/init/schema.d.ts

@@ -1,3 +1,5 @@
 export interface Schema {
  skipPackageJson?: boolean;
+


nitpick: extra space. nx format will probably catch it.

github-actions · 2023-03-03T14:08:21Z

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

FrozenPandaz requested review from AgentEnder, vsavkin, jaysoo, Coly010, meeroslav, barbados-clemens, mandarini, ndcunningham, nartc, xiongemi and leosvelperez as code owners February 16, 2023 22:04

FrozenPandaz changed the title ~~Ensure package2~~ fix(js): refactor ensurePackage Feb 16, 2023

vercel bot had a problem deploying to Preview February 16, 2023 22:10 Failure

AgentEnder previously requested changes Feb 16, 2023

View reviewed changes

nartc approved these changes Feb 16, 2023

View reviewed changes

FrozenPandaz force-pushed the ensure-package2 branch from c47f4c4 to 7f14351 Compare February 16, 2023 22:54

vercel bot deployed to Preview February 16, 2023 23:04 View deployment

leosvelperez requested changes Feb 17, 2023

View reviewed changes

mandarini approved these changes Feb 17, 2023

View reviewed changes

barbados-clemens approved these changes Feb 17, 2023

View reviewed changes

xiongemi approved these changes Feb 17, 2023

View reviewed changes

FrozenPandaz force-pushed the ensure-package2 branch from 7f14351 to 9bfc34b Compare February 17, 2023 20:28

vercel bot deployed to Preview February 17, 2023 20:37 View deployment

FrozenPandaz force-pushed the ensure-package2 branch from 9bfc34b to 60264ee Compare February 17, 2023 20:55

vercel bot deployed to Preview February 17, 2023 20:59 View deployment

FrozenPandaz force-pushed the ensure-package2 branch 3 times, most recently from 4371281 to a0900a4 Compare February 17, 2023 21:45

FrozenPandaz force-pushed the ensure-package2 branch 2 times, most recently from cdc6126 to c86ebea Compare February 18, 2023 01:52

vercel bot deployed to Preview February 18, 2023 01:57 View deployment

leosvelperez approved these changes Feb 20, 2023

View reviewed changes

FrozenPandaz force-pushed the ensure-package2 branch from c86ebea to 1e08e87 Compare February 21, 2023 16:30

vercel bot deployed to Preview February 21, 2023 16:40 View deployment

FrozenPandaz force-pushed the ensure-package2 branch from 1e08e87 to 261aa96 Compare February 21, 2023 21:50

vercel bot deployed to Preview February 21, 2023 21:57 View deployment

FrozenPandaz force-pushed the ensure-package2 branch from 261aa96 to 4db4b8c Compare February 21, 2023 22:04

vercel bot deployed to Preview February 21, 2023 22:14 View deployment

FrozenPandaz force-pushed the ensure-package2 branch from 4db4b8c to ef5f9a4 Compare February 21, 2023 23:52

vercel bot deployed to Preview February 22, 2023 00:02 View deployment

FrozenPandaz force-pushed the ensure-package2 branch from ef5f9a4 to 366a75f Compare February 22, 2023 01:21

vercel bot had a problem deploying to Preview February 22, 2023 01:28 Failure

meeroslav approved these changes Feb 22, 2023

View reviewed changes

barbados-clemens approved these changes Feb 22, 2023

View reviewed changes

FrozenPandaz force-pushed the ensure-package2 branch from 366a75f to 96e7ae7 Compare February 22, 2023 15:25

FrozenPandaz requested a review from JamesHenry as a code owner February 22, 2023 15:25

vercel bot deployed to Preview February 22, 2023 15:28 View deployment

nartc mentioned this pull request Feb 22, 2023

fix(js): move index.ts outside of src #15000

Closed

FrozenPandaz force-pushed the ensure-package2 branch from 96e7ae7 to b70852b Compare February 22, 2023 19:24

vercel bot deployed to Preview February 22, 2023 19:32 View deployment

fix(js): refactor ensurePackage

32c9de0

FrozenPandaz force-pushed the ensure-package2 branch from b70852b to 32c9de0 Compare February 22, 2023 22:52

vercel bot deployed to Preview February 22, 2023 22:55 View deployment

AgentEnder approved these changes Feb 22, 2023

View reviewed changes

FrozenPandaz merged commit fa6e8ea into nrwl:master Feb 22, 2023

github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(js): refactor ensurePackage #15074

fix(js): refactor ensurePackage #15074

FrozenPandaz commented Feb 16, 2023 •

edited

Loading

vercel bot commented Feb 16, 2023 •

edited

Loading

nx-cloud bot commented Feb 16, 2023 •

edited

Loading

nartc left a comment

barbados-clemens left a comment

meeroslav left a comment

barbados-clemens left a comment

barbados-clemens Feb 22, 2023

FrozenPandaz Feb 22, 2023

barbados-clemens Feb 22, 2023

github-actions bot commented Mar 3, 2023

		@@ -1,3 +1,5 @@
		export interface Schema {
		skipPackageJson?: boolean;

fix(js): refactor ensurePackage #15074

fix(js): refactor ensurePackage #15074

Conversation

FrozenPandaz commented Feb 16, 2023 • edited Loading

Current Behavior

Expected Behavior

Breaking Changes

Related Issue(s)

vercel bot commented Feb 16, 2023 • edited Loading

nx-cloud bot commented Feb 16, 2023 • edited Loading

☁️ Nx Cloud Report

nartc left a comment

Choose a reason for hiding this comment

barbados-clemens left a comment

Choose a reason for hiding this comment

meeroslav left a comment

Choose a reason for hiding this comment

barbados-clemens left a comment

Choose a reason for hiding this comment

barbados-clemens Feb 22, 2023

Choose a reason for hiding this comment

FrozenPandaz Feb 22, 2023

Choose a reason for hiding this comment

barbados-clemens Feb 22, 2023

Choose a reason for hiding this comment

github-actions bot commented Mar 3, 2023

FrozenPandaz commented Feb 16, 2023 •

edited

Loading

vercel bot commented Feb 16, 2023 •

edited

Loading

nx-cloud bot commented Feb 16, 2023 •

edited

Loading