Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): listing plugin capabilities causes issues when returning null #15308

Merged

Conversation

AgentEnder
Copy link
Member

@AgentEnder AgentEnder commented Feb 27, 2023

Current Behavior

loadNxPlugin may error when trying to load a module which is not an Nx plugin. This is because we set the name property on the object, which could be readonly, or similar.

getPluginCapabilities returns null on error, and calls loadNxPlugin.

Expected Behavior

getPluginCapabilities doesn't return null on error

Related Issue(s)

Fixes #15305

@vercel
Copy link

vercel bot commented Feb 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 27, 2023 at 11:51PM (UTC)

@FrozenPandaz FrozenPandaz merged commit 031005f into nrwl:master Feb 28, 2023
@github-actions
Copy link

github-actions bot commented Mar 6, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't use nx plugins - Cannot read properties of null (reading 'executors')
2 participants