Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): add warning if running on an outdated global install #15443

Merged
merged 5 commits into from Mar 18, 2023
Merged

fix(core): add warning if running on an outdated global install #15443

merged 5 commits into from Mar 18, 2023

Conversation

AgentEnder
Copy link
Member

Reapplies (#15442)

This reverts commit 1eee5f0.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Mar 4, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 17, 2023 at 3:44PM (UTC)

@nx-cloud
Copy link

nx-cloud bot commented Mar 4, 2023 •
edited

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 3eb7c15. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 8 targets

Sent with 💌 from NxCloud.

@AgentEnder AgentEnder force-pushed the revert/revert-global-warning branch from 6968563 to 071d3e2 Compare March 4, 2023 04:32
@AgentEnder AgentEnder force-pushed the revert/revert-global-warning branch from 071d3e2 to 5c01d9e Compare March 4, 2023 04:38
@AgentEnder AgentEnder force-pushed the revert/revert-global-warning branch from 5c01d9e to d79685a Compare March 4, 2023 04:42
meeroslav
meeroslav reviewed Mar 6, 2023
View reviewed changes
packages/nx/bin/nx.ts Outdated Show resolved Hide resolved
meeroslav
meeroslav approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@meeroslav meeroslav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments about the guide.

The rest looks good, not sure why it fails on CI.

@AgentEnder
Copy link
Member Author

Left some comments about the guide.

The rest looks good, not sure why it fails on CI.

I've not figured out why it fails on CI yet either, locally it passes.... I'm wondering if the global install isn't being picked up properly.

@AgentEnder AgentEnder merged commit 7740bb1 into nrwl:master Mar 18, 2023
FrozenPandaz pushed a commit that referenced this pull request Mar 22, 2023
@AgentEnder @FrozenPandaz
fix(core): add warning if running on an outdated global install (#15443)
7d525d2 
(cherry picked from commit 7740bb1)
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@meeroslav meeroslav meeroslav approved these changes

@bcabanes bcabanes bcabanes approved these changes

@mandarini mandarini mandarini approved these changes

@barbados-clemens barbados-clemens barbados-clemens approved these changes

@vsavkin vsavkin Awaiting requested review from vsavkin vsavkin is a code owner

@FrozenPandaz FrozenPandaz Awaiting requested review from FrozenPandaz FrozenPandaz is a code owner

@isaacplmann isaacplmann Awaiting requested review from isaacplmann

@juristr juristr Awaiting requested review from juristr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@AgentEnder @meeroslav @bcabanes @mandarini @barbados-clemens