Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): libraries should be buildable by default #15533

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

mandarini
Copy link
Member

Current Behavior

Recent updates to the @nrwl/js:lib generator changed the previous default behaviour. Before version 15.8.5, the @nrwl/js:lib generator would, by default, generate a buildable lib. In the schema.json buildable had a default value of true, and it would default to @nrwl/js:tsc as the build executor. The only way to get a non-buildable library would be to set buildable=false specifically.

This behaviour changed in the deprecation of the buildable option, and the use of bundler, since bundler would be set to none by default if not provided.

Expected Behavior

The new generator should respect the old functionality of having buildable libraries by default, and a library should not be buildable only if bundler is specifically set to none.

Related Issue(s)

Fixes #15516

@vercel
Copy link

vercel bot commented Mar 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 8, 2023 at 3:28PM (UTC)

@mandarini mandarini self-assigned this Mar 8, 2023
@mandarini mandarini merged commit 16ad308 into nrwl:master Mar 9, 2023
FrozenPandaz pushed a commit that referenced this pull request Mar 10, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JS generator generates new package without package.json
4 participants