-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(js): libraries should be buildable by default #15533
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mandarini
force-pushed
the
fix/jslib-buildable-default
branch
from
March 8, 2023 09:57
ae50a67
to
819a753
Compare
mandarini
requested review from
FrozenPandaz,
AgentEnder and
vsavkin
as code owners
March 8, 2023 09:57
mandarini
force-pushed
the
fix/jslib-buildable-default
branch
from
March 8, 2023 15:24
819a753
to
3e1f6a2
Compare
jaysoo
approved these changes
Mar 9, 2023
nartc
approved these changes
Mar 9, 2023
AgentEnder
approved these changes
Mar 9, 2023
FrozenPandaz
pushed a commit
that referenced
this pull request
Mar 10, 2023
(cherry picked from commit 16ad308)
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Recent updates to the
@nrwl/js:lib
generator changed the previous default behaviour. Before version15.8.5
, the@nrwl/js:lib
generator would, by default, generate a buildable lib. In theschema.json
buildable
had a default value oftrue
, and it would default to@nrwl/js:tsc
as thebuild
executor
. The only way to get a non-buildable library would be to setbuildable=false
specifically.This behaviour changed in the deprecation of the
buildable
option, and the use ofbundler
, sincebundler
would be set tonone
by default if not provided.Expected Behavior
The new generator should respect the old functionality of having buildable libraries by default, and a library should not be buildable only if
bundler
is specifically set tonone
.Related Issue(s)
Fixes #15516