Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix NX_PERF_LOGGING toggles #16054

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

meeroslav
Copy link
Contributor

Code toggles for NX_PERF_LOGGING expect it to be a boolean value, but setting the value to false (like we have it on CI) always enables it.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Apr 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2023 9:59am

@meeroslav meeroslav added the scope: core core nx functionality label Apr 3, 2023
@AgentEnder AgentEnder merged commit 45a1a6e into nrwl:master Apr 3, 2023
@github-actions
Copy link

github-actions bot commented Apr 9, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 9, 2023
@meeroslav meeroslav deleted the perf-logging-code-toggle branch April 27, 2023 09:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: core core nx functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants