Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): fix NX_PERF_LOGGING toggles #16054

Merged
merged 1 commit into from
Apr 3, 2023
Merged

fix(core): fix NX_PERF_LOGGING toggles #16054

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/nx/src/tasks-runner/run-command.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ function constructLifeCycles(lifeCycle: LifeCycle) {
const lifeCycles = [] as LifeCycle[];
lifeCycles.push(new StoreRunInformationLifeCycle());
lifeCycles.push(lifeCycle);
if (process.env.NX_PERF_LOGGING) {
if (process.env.NX_PERF_LOGGING === 'true') {
lifeCycles.push(new TaskTimingsLifeCycle());
}
if (process.env.NX_PROFILE) {
Expand Down
2 changes: 1 addition & 1 deletion packages/nx/src/utils/perf-logging.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { PerformanceObserver } from 'perf_hooks';

if (process.env.NX_PERF_LOGGING) {
if (process.env.NX_PERF_LOGGING === 'true') {
const obs = new PerformanceObserver((list) => {
for (const entry of list.getEntries()) {
console.log(`Time for '${entry.name}'`, entry.duration);
Expand Down
2 changes: 1 addition & 1 deletion packages/workspace/src/utils/perf-logging.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { PerformanceObserver } from 'perf_hooks';

if (process.env.NX_PERF_LOGGING) {
if (process.env.NX_PERF_LOGGING === 'true') {
const obs = new PerformanceObserver((list) => {
const entry = list.getEntries()[0];
console.log(`Time for '${entry.name}'`, entry.duration);
Expand Down