-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(misc): add --integrated option to nx init command #16148
Merged
leosvelperez
merged 1 commit into
nrwl:master
from
leosvelperez:angular/nx-init-integrated
Apr 12, 2023
Merged
feat(misc): add --integrated option to nx init command #16148
leosvelperez
merged 1 commit into
nrwl:master
from
leosvelperez:angular/nx-init-integrated
Apr 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
33a579e
to
9449d38
Compare
9449d38
to
aa532b1
Compare
mandarini
approved these changes
Apr 6, 2023
jaysoo
approved these changes
Apr 6, 2023
AgentEnder
approved these changes
Apr 6, 2023
xiongemi
approved these changes
Apr 11, 2023
AgentEnder
approved these changes
Apr 11, 2023
Coly010
approved these changes
Apr 12, 2023
bcabanes
approved these changes
Apr 12, 2023
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
The
nx init
command doesn't support migrating an Angular CLI workspace to an integrated Nx workspace. While it currently supports it for CRA projects, the--integrated
flag is sort of "hidden" and handled internally by the CRA to Nx flow implementation.Expected Behavior
The
nx init
command should support migrating an Angular CLI workspace to an integrated Nx workspace. The--integrated
flag should be part of thenx init
command itself so it's included in the help and docs.NOTE: The PR still keeps the
--interactive
flag hidden from the docs and help until the feature is released.Related Issue(s)
Fixes #