-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nx-plugin): simplify generated plugin code #16590
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
// `nx reset` kills the daemon, and performs | ||
// some work which can help clean up e2e leftovers | ||
runNxCommandAsync('reset'); | ||
// await unlink(cwd); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will fail if daemon is active, since there is an open file handle to the log file
92f2396
to
b17a297
Compare
if (options.e2eTestRunner !== 'none') { | ||
tasks.push(await addE2eProject(host, options)); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we just never creating this e2e project?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're waiting until we have a better solution.
a9badf3
to
7973b38
Compare
7973b38
to
c53757a
Compare
nxCloud: false, | ||
packageManager: 'npm', | ||
// This assumes "<%= preset %>" and "<%= projectName %>" are at the same version | ||
// eslint-disable-next-line @typescript-eslint/no-var-requires | ||
presetVersion: require('../package.json').version, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this typing
c53757a
to
af6e647
Compare
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
Nx generates a lot of custom functions for plugin e2e tests which can be confusing.
Expected Behavior
Nx generates more native code which should be better understood out of the box.
Related Issue(s)
Fixes #