feat(nx-plugin): simplify generated plugin code #16590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrozenPandaz
requested review from
AgentEnder,
nartc,
jaysoo,
ndcunningham,
vsavkin and
JamesHenry
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
AgentEnder
requested changes
Apr 26, 2023
| // `nx reset` kills the daemon, and performs | ||
| // some work which can help clean up e2e leftovers | ||
| runNxCommandAsync('reset'); | ||
| // await unlink(cwd); |
There was a problem hiding this comment.
This will fail if daemon is active, since there is an open file handle to the log file
FrozenPandaz
force-pushed
the
fix-plugins
branch
2 times, most recently
from
92f2396
to
b17a297
Compare
AgentEnder
reviewed
Apr 26, 2023
Comment on lines
-42
to
-44
| if (options.e2eTestRunner !== 'none') { | ||
| tasks.push(await addE2eProject(host, options)); | ||
| } |
There was a problem hiding this comment.
Are we just never creating this e2e project?
There was a problem hiding this comment.
We're waiting until we have a better solution.
FrozenPandaz
force-pushed
the
fix-plugins
branch
2 times, most recently
from
a9badf3
to
7973b38
Compare
FrozenPandaz
force-pushed
the
fix-plugins
branch
from
7973b38
to
c53757a
Compare
FrozenPandaz
commented
Apr 26, 2023
| nxCloud: false, | ||
| packageManager: 'npm', | ||
| // This assumes "<%= preset %>" and "<%= projectName %>" are at the same version | ||
| // eslint-disable-next-line @typescript-eslint/no-var-requires | ||
| presetVersion: require('../package.json').version, |
There was a problem hiding this comment.
Remove this typing
AgentEnder
approved these changes
Apr 26, 2023
FrozenPandaz
force-pushed
the
fix-plugins
branch
from
c53757a
to
af6e647
Compare
This was referenced Apr 28, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Nx generates a lot of custom functions for plugin e2e tests which can be confusing.
Expected Behavior
Nx generates more native code which should be better understood out of the box.
Related Issue(s)
Fixes #