Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): throw error when no parent module found #16728

Merged

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented May 3, 2023

Current Behavior

When there are no parent modules to add a component to, the generator fails with a cryptic error.

Expected Behavior

We should throw a better when a parent module cannot be found

Related Issue(s)

Fixes #16689

@Coly010 Coly010 requested a review from leosvelperez as a code owner May 3, 2023 15:06
@Coly010 Coly010 self-assigned this May 3, 2023
@vercel
Copy link

vercel bot commented May 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) May 3, 2023 3:07pm

@Coly010 Coly010 merged commit c2e88ad into nrwl:master May 3, 2023
@Coly010 Coly010 deleted the angular/throw-error-when-no-parent-module branch May 3, 2023 15:39
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants