fix(angular): automatically skip remotes not in the current workspace #17473 #17497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit cec3609. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
mandarini
approved these changes
Jun 8, 2023
leosvelperez
approved these changes
Jun 8, 2023
packages/angular/src/builders/module-federation-dev-server/module-federation-dev-server.impl.ts
Outdated
Show resolved
Hide resolved
packages/react/src/executors/module-federation-dev-server/module-federation-dev-server.impl.ts
Outdated
Show resolved
Hide resolved
|
Thank you for the quick turnaround on this! |
mandarini
approved these changes
Jun 12, 2023
packages/react/src/executors/module-federation-dev-server/module-federation-dev-server.impl.ts
Outdated
Show resolved
Hide resolved
Coly010
force-pushed
the
fix/skip-remotes
branch
from
c17e256
to
c8066ab
Compare
Coly010
force-pushed
the
fix/skip-remotes
branch
2 times, most recently
from
d110a0f
to
58c71ff
Compare
Coly010
force-pushed
the
fix/skip-remotes
branch
from
58c71ff
to
52cc9c7
Compare
packages/react/src/executors/module-federation-dev-server/module-federation-dev-server.impl.ts
Outdated
Show resolved
Hide resolved
...eact/src/executors/module-federation-ssr-dev-server/module-federation-ssr-dev-server.impl.ts
Outdated
Show resolved
Hide resolved
packages/angular/src/builders/module-federation-dev-server/module-federation-dev-server.impl.ts
Outdated
Show resolved
Hide resolved
Coly010
force-pushed
the
fix/skip-remotes
branch
from
52cc9c7
to
ce4b5fb
Compare
Coly010
force-pushed
the
fix/skip-remotes
branch
from
ce4b5fb
to
df46ac7
Compare
Coly010
changed the title
Coly010
force-pushed
the
fix/skip-remotes
branch
from
df46ac7
to
cec3609
Compare
leosvelperez
approved these changes
Jun 30, 2023
isaacplmann
approved these changes
Jun 30, 2023
mandarini
approved these changes
Jul 3, 2023
isaacplmann
approved these changes
Jul 5, 2023
AgentEnder
approved these changes
Jul 5, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
We error if we try to serve remotes that are not in the current workspace.
Expected Behavior
Skip trying to serve remotes that we cannot find in the current workspace
Related Issue(s)
Fixes #17473
Fixes #17957