Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

npm-like version resolving for nx migrate #21418

Closed
1 task
Den-dp opened this issue Jan 30, 2024 · 1 comment · Fixed by #23450
Closed
1 task

npm-like version resolving for nx migrate #21418

Den-dp opened this issue Jan 30, 2024 · 1 comment · Fixed by #23450
Assignees
@leosvelperez
Labels
outdated scope: core core nx functionality type: feature

Comments

@Den-dp
Copy link
Contributor

Den-dp commented Jan 30, 2024

Description

npx nx migrate 17.2 should migrate to the latest patch version of nx (f.e. 17.2.8), cause currently it installs 17.2.0

image

Motivation

I want to install the latest possible version of 17.2 without the need to specify it explicitly (pretty natural behavior for npm ecosystem).

Mainly needed cause latest (17.3.0 at the moment) is not stable enough for me #21412 which is why I want to use the previous release.

Suggested Implementation

I'd expected it to work the same way as npm install nx@17.2 where it resolves 17.2 to the latest 17.2.8

Alternate Implementations
@AgentEnder AgentEnder added the scope: core core nx functionality label Feb 2, 2024
@leosvelperez leosvelperez mentioned this issue May 16, 2024
Merged
leosvelperez added a commit that referenced this issue May 16, 2024
@leosvelperez
feat(core): resolve nx migrate target version against registry (#23450)
8685e10 
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #21418
FrozenPandaz pushed a commit that referenced this issue May 21, 2024
@leosvelperez @FrozenPandaz
feat(core): resolve nx migrate target version against registry (#23450)
c071590 
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #21418

(cherry picked from commit 8685e10)
@github-actions GitHub Actions
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@leosvelperez leosvelperez

Labels
outdated scope: core core nx functionality type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(core): resolve nx migrate target version against registry nrwl/nx
3 participants
@Den-dp @AgentEnder @leosvelperez