Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration "rm-default-collection-npm-scope" logs [object Object] #21875

Closed
1 of 4 tasks
rcfox opened this issue Feb 19, 2024 · 1 comment · Fixed by #21953
Closed
1 of 4 tasks

Migration "rm-default-collection-npm-scope" logs [object Object] #21875

rcfox opened this issue Feb 19, 2024 · 1 comment · Fixed by #21953
Assignees

Comments

@rcfox
Copy link

rcfox commented Feb 19, 2024

Current Behavior

While migrating from v16.1.4 to v18.0.4, I noticed that the rm-default-collection-npm-scope migration logged a yellow [object Object]

Expected Behavior

Expected a warning message to be displayed in the logs. I assume this is due to the logger not being initialized correctly.

I think this is the warning that was supposed to be logged:

Note: The 18.0.0-disable-adding-plugins-for-existing-workspaces migration did correctly log a warning message.

GitHub Repo

No response

Steps to Reproduce

  1. Start on nx v16.1.4
  2. npx nx migrate latest
  3. yarn
  4. npx nx migrate --run-migrations

Nx Report

Before:

   Node   : 18.13.0
   OS     : linux x64
   yarn   : 3.6.0
   Hasher : Native
   
   nx                 : 16.1.4
   @nx/js             : 16.1.4
   @nx/jest           : 16.1.4
   @nx/linter         : 16.1.4
   @nx/workspace      : 16.1.4
   @nx/cypress        : 16.1.4
   @nx/devkit         : 16.1.4
   @nx/eslint-plugin  : 16.1.4
   @nx/express        : 16.1.4
   @nx/nest           : 16.1.4
   @nx/node           : 16.1.4
   @nx/react          : 16.1.4
   @nrwl/tao          : 16.1.4
   @nx/web            : 16.1.4
   @nx/webpack        : 16.1.4
   typescript         : 5.3.3

After:


   Node   : 18.13.0
   OS     : linux-x64
   yarn   : 3.6.0
   
   nx                 : 18.0.4
   @nx/js             : 18.0.4
   @nx/jest           : 18.0.4
   @nx/linter         : 18.0.4
   @nx/eslint         : 18.0.4
   @nx/workspace      : 18.0.4
   @nx/cypress        : 18.0.4
   @nx/devkit         : 18.0.4
   @nx/eslint-plugin  : 18.0.4
   @nx/express        : 18.0.4
   @nx/nest           : 18.0.4
   @nx/node           : 18.0.4
   @nx/react          : 18.0.4
   @nrwl/tao          : 18.0.4
   @nx/web            : 18.0.4
   @nx/webpack        : 18.0.4
   typescript         : 5.3.3

Failure Logs

>  NX   Running migrations from 'migrations.json'

Ran 16.6.0-prefix-outputs from nx
  Prefix outputs with {workspaceRoot}/{projectRoot} if needed

  UPDATE apps/cortex-app/project.json
  UPDATE libs/db-orm/project.json
---------------------------------------------------------
Ran 17.0.0-move-cache-directory from nx
  Updates the default cache directory to .nx/cache

  UPDATE .prettierignore
---------------------------------------------------------
Ran 17.0.0-use-minimal-config-for-tasks-runner-options from nx
  Use minimal config for tasksRunnerOptions

  UPDATE nx.json
---------------------------------------------------------
[object Object]
Ran rm-default-collection-npm-scope from nx
  Migration for v17.0.0-rc.1

  UPDATE nx.json
---------------------------------------------------------
NX The NX_ADD_PLUGINS=false environment variable was added to your .env file for backwards compatibility. However, your .env is ignored by git. Other contributors should add this key to their .env file or ensure that the environment variable is set to false when generating code with Nx.
Ran 18.0.0-disable-adding-plugins-for-existing-workspaces from nx
  Updates .env to disabled adding plugins when generating projects in an existing Nx workspace

  CREATE .env
---------------------------------------------------------
Ran update-16-8-0-cypress-13 from @nx/cypress
  Update to Cypress v13. Most noteable change is video recording is off by default. This migration will only update if the workspace is already on Cypress v12. https://docs.cypress.io/guides/references/migration-guide#Migrating-to-Cypress-130

  UPDATE package.json
---------------------------------------------------------
Ran add-test-setup-to-inputs-ignore from @nx/jest
  Add test-setup.ts to ignored files in production input

  UPDATE nx.json
---------------------------------------------------------
Ran move-options-to-target-defaults from @nx/jest
  Move jest executor options to nx.json targetDefaults

  UPDATE nx.json
  UPDATE apps/cortex-app/project.json
  UPDATE apps/crtx-nest/project.json
  UPDATE apps/data-seeder/project.json
  UPDATE apps/factory-configuration/project.json
  UPDATE apps/migrator/project.json
  UPDATE apps/pe-bulk-importer/project.json
  UPDATE libs/crtx-protos/project.json
  UPDATE libs/crtx-protos-web/project.json
  UPDATE libs/db-migrations/project.json
  UPDATE libs/db-orm/project.json
  UPDATE libs/grpc-utils/project.json
  UPDATE libs/i18n/project.json
  UPDATE libs/labels/project.json
  UPDATE libs/pb-entity-conversion/project.json
  UPDATE libs/proto-loader-wrapper/project.json
  UPDATE libs/sheet-utils/project.json
  UPDATE libs/utils/project.json
---------------------------------------------------------
Ran update-16-2-0-remove-package from @nx/react
  Remove react-test-renderer from package.json

  UPDATE package.json
---------------------------------------------------------
Ran update-16-7-0-add-typings from @nx/react
  Add @nx/react types to tsconfig types array

  UPDATE apps/cortex-app/tsconfig.app.json
  UPDATE apps/cortex-app/tsconfig.spec.json
---------------------------------------------------------
Ran explicitly-set-projects-to-update-buildable-deps from @nx/js
  Explicitly set 'updateBuildableProjectDepsInPackageJson' to 'true' in targets that rely on that value as the default.

  UPDATE libs/proto-loader-wrapper/project.json
  UPDATE libs/crtx-protos-web/project.json
  UPDATE libs/crtx-protos/project.json
  UPDATE libs/logging/project.json
  UPDATE libs/utils/project.json
---------------------------------------------------------
Ran update-17-2-1-webpack-config-setup from @nx/webpack
  Add webpack.config.js file when webpackConfig is not defined

  CREATE apps/data-seeder/webpack.config.js
  UPDATE apps/data-seeder/project.json
  CREATE apps/factory-configuration/webpack.config.js
  UPDATE apps/factory-configuration/project.json
  CREATE apps/migrator/webpack.config.js
  UPDATE apps/migrator/project.json
  CREATE apps/pe-bulk-importer/webpack.config.js
  UPDATE apps/pe-bulk-importer/project.json
---------------------------------------------------------
Ran update-17-0-0-rename-to-eslint from @nx/linter
  update-17-0-0-rename-to-eslint

  UPDATE package.json
  UPDATE apps/cortex-app/project.json
  UPDATE apps/cortex-app-e2e/project.json
  UPDATE apps/crtx-nest/project.json
  UPDATE apps/data-seeder/project.json
  UPDATE apps/factory-configuration/project.json
  UPDATE apps/migrator/project.json
  UPDATE apps/pe-bulk-importer/project.json
  UPDATE libs/crtx-protos/project.json
  UPDATE libs/crtx-protos-web/project.json
  UPDATE libs/db-migrations/project.json
  UPDATE libs/db-orm/project.json
  UPDATE libs/grpc-utils/project.json
  UPDATE libs/i18n/project.json
  UPDATE libs/labels/project.json
  UPDATE libs/pb-entity-conversion/project.json
  UPDATE libs/proto-loader-wrapper/project.json
  UPDATE libs/sheet-utils/project.json
  UPDATE libs/utils/project.json
  UPDATE migrations.json
---------------------------------------------------------
Ran simplify-eslint-patterns from @nx/linter
  Simplify eslintFilePatterns

  UPDATE apps/cortex-app/project.json
  UPDATE apps/cortex-app-e2e/project.json
  UPDATE apps/crtx-nest/project.json
  UPDATE apps/data-seeder/project.json
  UPDATE apps/factory-configuration/project.json
  UPDATE apps/migrator/project.json
  UPDATE apps/pe-bulk-importer/project.json
  UPDATE libs/crtx-protos/project.json
  UPDATE libs/crtx-protos-web/project.json
  UPDATE libs/db-migrations/project.json
  UPDATE libs/db-orm/project.json
  UPDATE libs/grpc-utils/project.json
  UPDATE libs/i18n/project.json
  UPDATE libs/labels/project.json
  UPDATE libs/pb-entity-conversion/project.json
  UPDATE libs/proto-loader-wrapper/project.json
  UPDATE libs/sheet-utils/project.json
  UPDATE libs/utils/project.json
---------------------------------------------------------
Ran move-options-to-target-defaults from @nx/linter
  Move executor options to target defaults

  UPDATE nx.json
---------------------------------------------------------

 >  NX   Running 'yarn' to make sure necessary packages are installed

<snip>

 >  NX   Successfully finished running migrations from 'migrations.json'. This workspace is up to date!

Package Manager Version

No response

Operating System

  • macOS
  • Linux
  • Windows
  • Other (Please specify)

Additional Information

No response

Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants