externalNodes incorrectly populated on pnpm@^9

[DenizUgur]

Current Behavior

I've came across this issue while using @nx/dependency-checks eslint rule, where it failed to detect the dependencies in my source files. After debugging the linter I've realized that the actual problem is with how Nx parses pnpm lock file.

I've added a breakpoint on the following line to see how does this rule understands dependencies:

nx/packages/js/src/utils/find-npm-dependencies.ts

Line 126 in abd80cf

const externalDep = projectGraph.externalNodes[target];

It turns out it cannot match the discovered dependency with the ones extracted from lock file because the version is bundled with the package name. Which you can see in the following screenshot.

related #22247

Expected Behavior

I expect @nx/dependency-checks to work properly and tell me which dependencies are missing from my package.json file.

GitHub Repo

No response

Steps to Reproduce

1. Install pnpm@^9 and run @nx/dependency-checks rule on a project
2. Removing or adding dependencies in your source files shouldn't change the output of this eslint rule

Note

To me this seems like a very basic problem so I sincerely belive this should be easily reproducible. If not, let me know and I'll create a devbox for it.

Nx Report

Node   : 20.10.0
OS     : linux-x64
pnpm   : 9.1.0-0

nx (global)        : 18.3.4
nx                 : 18.3.4
@nx/js             : 18.3.4
@nx/eslint         : 18.3.4
@nx/workspace      : 18.3.4
@nx/cypress        : 18.3.4
@nx/eslint-plugin  : 18.3.4
@nx/react          : 18.3.4
@nrwl/tao          : 18.3.4
@nx/vite           : 18.3.4
@nx/web            : 18.3.4
typescript         : 5.4.5
---------------------------------------
Registered Plugins:
@nx/eslint/plugin
@nx/vite/plugin

Failure Logs

No response

Package Manager Version

No response

Operating System

• macOS
• Linux
• Windows
• Other (Please specify)

Additional Information

Using pnpm@^8 is working fine

[AgentEnder]

Closing this out as a duplicate of #22850, which is the tracking issue for pnpm 9 support.

[github-actions]

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.