Lint breaks after updating from 19.0.5 to 19.0.6 #25319

TomTomB · 2024-05-23T08:49:21Z

Current Behavior

After updating to nx 19.0.6, linting will fail inside an angular monorepo. This only ocurres if the user has updated the @typescript-eslint/* packages from 7.3.0 to e.g. latest (7.10.0). I guess this has to do with #24632.

Expected Behavior

Linting should not break during patch releases.

GitHub Repo

No response

Steps to Reproduce

Create a default nx monorepo with the angular preset and choose integrated instead of standalone.
Update @typescript-eslint/eslint-plugin and @typescript-eslint/parser to 7.10.0
Lint. npx nx run-many -t lint --skip-nx-cache

Nx Report

Node   : 20.11.1
OS     : linux-x64 (WSL)
yarn   : 1.22.21

nx                 : 19.0.6
@nx/js             : 19.0.6
@nx/jest           : 19.0.6
@nx/linter         : 19.0.6
@nx/eslint         : 19.0.6
@nx/workspace      : 19.0.6
@nx/angular        : 19.0.6
@nx/devkit         : 19.0.6
@nx/eslint-plugin  : 19.0.6
@nx/playwright     : 19.0.6
@nrwl/tao          : 19.0.6
@nx/web            : 19.0.6
@nx/webpack        : 19.0.6
typescript         : 5.4.5
---------------------------------------
Registered Plugins:
@nx/playwright/plugin
@nx/eslint/plugin

Failure Logs

✖  nx run eslint-issue:lint
      Linting "eslint-issue"...
      
       NX   Error while loading rule '@angular-eslint/template/banana-in-box': You have used a rule which requires '@angular-eslint/template-parser' to be used as the 'parser' in your ESLint config.
      
      Occurred while linting some/file/path....

Package Manager Version

No response

Operating System

macOS
Linux
Windows
Other (Please specify)

Additional Information

No response

The text was updated successfully, but these errors were encountered:

mgansler · 2024-05-23T08:56:02Z

I have noticed a very similar behaviour:

Linting "components"...
 NX   context.getScope is not a function
Occurred while linting /builds/mgansler/plusone/libs/components/cypress/support/commands.ts:14
Rule: "import/no-amd"

Worked fine with 19.0.5 but is broken with 19.0.6 and no other changes.
The version of @typescript-eslint/* seems to make no difference for me, same result with 7.3.0 and 7.10.0

SteveW94 · 2024-05-23T11:11:25Z

I experienced the same.

Due to this the Update PR is currently on hold

Tijawk · 2024-05-23T13:10:13Z

I have huge performance issue with lerna since I have updated nx from 19.0.5 to 19.0.6. I use @typescript-eslint/*@7.10.0 too,

I think it's the same probleme. I have rollback to 19.0.5.

FrozenPandaz · 2024-05-23T14:35:27Z

I have huge performance issue with lerna since I have updated nx from 19.0.5 to 19.0.6. I use @typescript-eslint/*@7.10.0 too,

I think it's the same probleme. I have rollback to 19.0.5.

Mm.. this isn't much details but I think this might be a separate issue unrelated to this one.

NX context.getScope is not a function

Thank you for reporting it. We'll look into it.

JamesHenry · 2024-05-23T14:45:55Z

@TomTomB @mgansler @SteveW94 Maybe you are now pulling in eslint v9?

Please try running this command or similar and see what version of eslint is getting pulled in:

npm ls eslint

JamesHenry · 2024-05-23T14:47:55Z

@Tijawk Please open a fresh issue for your case with maximum information/steps to reproduce

TomTomB · 2024-05-23T15:32:19Z

@JamesHenry Both eslint versions (8.57.x, and 9.x) result in the same error.

SteveW94 · 2024-05-23T15:55:24Z

@JamesHenry
This is before the installation of 19.0.6

As you can see no eslint 9
Just after installation of 19.0.6

You can see, @nx/eslint@19.0.6 is the culprit, as it references eslint 9!

In my package .json there is:
"eslint": "8.57.0" pinned. So no Semver Tag or anything.

So I would say, this way ESLint "sneaks" in there should not be intended!

mgansler · 2024-05-23T16:11:01Z

with 19.0.5:

yarn why v1.22.22
[1/4] 🤔  Why do we have the module "eslint"...?
[2/4] 🚚  Initialising dependency graph...
[3/4] 🔍  Finding dependency...
[4/4] 🚡  Calculating file sizes...
=> Found "eslint@8.57.0"
info Has been hoisted to "eslint"
info Reasons this module exists
   - Specified in "devDependencies"
   - Hoisted from "@nx#eslint#eslint"
info Disk size without dependencies: "5.5MB"
info Disk size with unique dependencies: "15.11MB"
info Disk size with transitive dependencies: "18.44MB"
info Number of shared dependencies: 80

With 19.0.6:

yarn why v1.22.22
[1/4] 🤔  Why do we have the module "eslint"...?
[2/4] 🚚  Initialising dependency graph...
[3/4] 🔍  Finding dependency...
[4/4] 🚡  Calculating file sizes...
=> Found "eslint@8.57.0"
info Has been hoisted to "eslint"
info This module exists because it's specified in "devDependencies".
info Disk size without dependencies: "5.38MB"
info Disk size with unique dependencies: "14.99MB"
info Disk size with transitive dependencies: "18.29MB"
info Number of shared dependencies: 82
=> Found "@nx/eslint#eslint@9.3.0"
info This module exists because "@nx#eslint" depends on it.
info Disk size without dependencies: "3.8MB"
info Disk size with unique dependencies: "11.71MB"
info Disk size with transitive dependencies: "15.73MB"
info Number of shared dependencies: 80

And with eslint removed from my package.json (and Nx 19.0.6):

y why eslint
yarn why v1.22.22
[1/4] 🤔  Why do we have the module "eslint"...?
[2/4] 🚚  Initialising dependency graph...
[3/4] 🔍  Finding dependency...
[4/4] 🚡  Calculating file sizes...
=> Found "eslint@9.3.0"
info Reasons this module exists
   - "@nx#eslint" depends on it
   - Hoisted from "@nx#eslint#eslint"
info Disk size without dependencies: "5.34MB"
info Disk size with unique dependencies: "14.5MB"
info Disk size with transitive dependencies: "18.33MB"
info Number of shared dependencies: 71

Same error though, still context.getScope is not a function

mgansler · 2024-05-23T16:16:48Z

When I force eslint to 8.57.0, linting works:

 "resolutions": {
    "eslint": "8.57.0"
  }

yarn why v1.22.22
[1/4] 🤔  Why do we have the module "eslint"...?
[2/4] 🚚  Initialising dependency graph...
[3/4] 🔍  Finding dependency...
[4/4] 🚡  Calculating file sizes...
=> Found "eslint@8.57.0"
info Has been hoisted to "eslint"
info Reasons this module exists
   - Specified in "devDependencies"
   - Hoisted from "@nx#eslint#eslint"
info Disk size without dependencies: "5.5MB"
info Disk size with unique dependencies: "15.11MB"
info Disk size with transitive dependencies: "18.44MB"
info Number of shared dependencies: 80

Can someone with npm try this with overrides instead of resolutions?

## Current Behavior  `@nx/eslint` is bringing in `eslint v9` prematurely. ## Expected Behavior  `@nx/eslint` should not bring in `eslint v9` yet. Though, it does have support for having `v9` installed at the workspace level. ## Related Issue(s)  Fixes #25319

SteveW94 · 2024-05-23T17:25:42Z

👍🏼

## Current Behavior  `@nx/eslint` is bringing in `eslint v9` prematurely. ## Expected Behavior  `@nx/eslint` should not bring in `eslint v9` yet. Though, it does have support for having `v9` installed at the workspace level. ## Related Issue(s)  Fixes #25319 (cherry picked from commit f728058)

JamesHenry · 2024-05-24T12:25:52Z

FYI we confirmed this is only an issue with yarn. The other package managers behave how we expected and do not force the eslint v9 dependency upon you. We are still discussing the ultimate resolution to this.

terrymun · 2024-06-15T02:23:00Z

Can confirm that this is also an issue with pnpm too. Currently on nx@19.2.3 and upgrading eslint from 8.57.0 → 9.5.0 is causing issues.

JamesHenry · 2024-06-19T00:25:40Z

@terrymun It's better to open a fresh issue with full context about your specific circumstances, rather than commenting on closed issues. If you are choosing to upgrade from 8 to 9 as your comment suggests then it already confirms it is not directly related to this specific issue.

If you open a fresh issue the team will happily take a look

TomTomB added the type: bug label May 23, 2024

FrozenPandaz assigned leosvelperez May 23, 2024

FrozenPandaz added the scope: linter Issues related to Eslint support in Nx label May 23, 2024

FrozenPandaz mentioned this issue May 23, 2024

fix(linter): only depend on eslint v8 #25938

Merged

FrozenPandaz closed this as completed in #25938 May 23, 2024

nrwl locked as resolved and limited conversation to collaborators Jun 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Lint breaks after updating from 19.0.5 to 19.0.6 #25319

Lint breaks after updating from 19.0.5 to 19.0.6 #25319

TomTomB commented May 23, 2024

mgansler commented May 23, 2024 •

edited

Loading

SteveW94 commented May 23, 2024

Tijawk commented May 23, 2024 •

edited

Loading

FrozenPandaz commented May 23, 2024

JamesHenry commented May 23, 2024

JamesHenry commented May 23, 2024

TomTomB commented May 23, 2024

SteveW94 commented May 23, 2024

mgansler commented May 23, 2024

mgansler commented May 23, 2024 •

edited

Loading

SteveW94 commented May 23, 2024

JamesHenry commented May 24, 2024 •

edited

Loading

terrymun commented Jun 15, 2024

JamesHenry commented Jun 19, 2024

Lint breaks after updating from 19.0.5 to 19.0.6 #25319

Lint breaks after updating from 19.0.5 to 19.0.6 #25319

Comments

TomTomB commented May 23, 2024

Current Behavior

Expected Behavior

GitHub Repo

Steps to Reproduce

Nx Report

Failure Logs

Package Manager Version

Operating System

Additional Information

mgansler commented May 23, 2024 • edited Loading

SteveW94 commented May 23, 2024

Tijawk commented May 23, 2024 • edited Loading

FrozenPandaz commented May 23, 2024

JamesHenry commented May 23, 2024

JamesHenry commented May 23, 2024

TomTomB commented May 23, 2024

SteveW94 commented May 23, 2024

mgansler commented May 23, 2024

mgansler commented May 23, 2024 • edited Loading

SteveW94 commented May 23, 2024

JamesHenry commented May 24, 2024 • edited Loading

terrymun commented Jun 15, 2024

JamesHenry commented Jun 19, 2024

mgansler commented May 23, 2024 •

edited

Loading

Tijawk commented May 23, 2024 •

edited

Loading

mgansler commented May 23, 2024 •

edited

Loading

JamesHenry commented May 24, 2024 •

edited

Loading