You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Generating a new remix app in a blank nx workspace gives peer dependency conflicts. (Follow up of #26082 )
Expected Behavior
A generated app should always be able to be installed without any problems.
GitHub Repo
No response
Steps to Reproduce
npx create-nx-workspace@latest --ci skip nx-remix --preset ts
cd nx-remix
npm i -D @nx/remix
npx nx g @nx/remix:application --directory apps/remix-app --name remix-app --projectNameAndRootFormat as-provided --unitTestRunner vitest --e2eTestRunner playwright
npm install
❯ npm i
npm error code ERESOLVE
npm error ERESOLVE could not resolve
npm error
npm error While resolving: eslint-plugin-jest@26.9.0
npm error Found: @typescript-eslint/eslint-plugin@7.13.0
npm error node_modules/@typescript-eslint/eslint-plugin
npm error dev @typescript-eslint/eslint-plugin@"^7.3.0" from the root project
npm error
npm error Could not resolve dependency:
npm error peerOptional @typescript-eslint/eslint-plugin@"^5.0.0" from eslint-plugin-jest@26.9.0
npm error node_modules/eslint-plugin-jest
npm error eslint-plugin-jest@"^26.9.0" from @remix-run/eslint-config@2.9.2
npm error node_modules/@remix-run/eslint-config
npm error dev @remix-run/eslint-config@"^2.8.1" from the root project
npm error peerOptional eslint-plugin-jest@">=25" from eslint-plugin-playwright@0.15.3
npm error node_modules/eslint-plugin-playwright
npm error dev eslint-plugin-playwright@"^0.15.3" from the root project
npm error
npm error Conflicting peer dependency: @typescript-eslint/eslint-plugin@5.62.0
npm error node_modules/@typescript-eslint/eslint-plugin
npm error peerOptional @typescript-eslint/eslint-plugin@"^5.0.0" from eslint-plugin-jest@26.9.0
npm error node_modules/eslint-plugin-jest
npm error eslint-plugin-jest@"^26.9.0" from @remix-run/eslint-config@2.9.2
npm error node_modules/@remix-run/eslint-config
npm error dev @remix-run/eslint-config@"^2.8.1" from the root project
npm error peerOptional eslint-plugin-jest@">=25" from eslint-plugin-playwright@0.15.3
npm error node_modules/eslint-plugin-playwright
npm error dev eslint-plugin-playwright@"^0.15.3" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
npm error
npm error
npm error For a full report see:
npm error /Users/thdk/.npm/_logs/2024-06-13T11_17_25_577Z-eresolve-report.txt
npm error A complete log of this run can be found in: /Users/thdk/.npm/_logs/2024-06-13T11_17_25_577Z-debug-0.log
I believe the @remix-run/eslint-config can be removed from the dependencies since it's also no longer included when generating a new remix app with npx create-remix@latest remix-blank.
Below is the package.json that gets generated by using create-remix.
…x apps (#26568)
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->
<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->
<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->
## Current Behavior
<!-- This is the behavior we have today -->
When a new remix app is generated with @nx/remix, it can't be installed
due to peer dependencies that are introduced by
@remix-run/eslint-config. This dependency though is not used in the nx
workspace and has also been removed from the official create-remix
method.
## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->
Running `npm install` should not throw errors after a remix application
was added to the nx workspace.
## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->
Fixes#26540
(cherry picked from commit 1e41672)
Current Behavior
Generating a new remix app in a blank nx workspace gives peer dependency conflicts. (Follow up of #26082 )
Expected Behavior
A generated app should always be able to be installed without any problems.
GitHub Repo
No response
Steps to Reproduce
Nx Report
Failure Logs
No response
Package Manager Version
No response
Operating System
Additional Information
I believe the @remix-run/eslint-config can be removed from the dependencies since it's also no longer included when generating a new remix app with
npx create-remix@latest remix-blank
.Below is the
package.json
that gets generated by usingcreate-remix
.The text was updated successfully, but these errors were encountered: