-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(remix): don't add @remix-run/eslint-config dependency to new remix apps #26568
fix(remix): don't add @remix-run/eslint-config dependency to new remix apps #26568
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit ecf7b2d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
@Coly010 I've added a test using npm (instead of yarn) and added a If needed, I can add the |
b7d5566
to
e45e838
Compare
591a37d
to
ecf7b2d
Compare
Thank you @thdk for the contribution! It is very much appreciated! |
…x apps (#26568) <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> When a new remix app is generated with @nx/remix, it can't be installed due to peer dependencies that are introduced by @remix-run/eslint-config. This dependency though is not used in the nx workspace and has also been removed from the official create-remix method. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> Running `npm install` should not throw errors after a remix application was added to the nx workspace. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #26540 (cherry picked from commit 1e41672)
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
When a new remix app is generated with @nx/remix, it can't be installed due to peer dependencies that are introduced by @remix-run/eslint-config. This dependency though is not used in the nx workspace and has also been removed from the official create-remix method.
Expected Behavior
Running
npm install
should not throw errors after a remix application was added to the nx workspace.Related Issue(s)
Fixes #26540