Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does the --with-deps does something when used on nx serve? #3501

Closed
maxime1992 opened this issue Aug 11, 2020 · 12 comments
Closed

Does the --with-deps does something when used on nx serve? #3501

maxime1992 opened this issue Aug 11, 2020 · 12 comments

Comments

@maxime1992
Copy link

Description

I've recently converted all my libs to be buildables.

It's helping for the build but I don't think I've noticed any difference when doing nx serve my-app --with-deps

We've got quite a huge number of libs and I'd expect some perf improvement by doing that but I don't feel like that the case. Maybe it's just me or the fact that part of our app is still in the main app.

Can anyone confirm that --with-deps should help when used with nx serve?

Thanks

@FrozenPandaz
Copy link
Collaborator

Currently, serve does not really use buildable library computation. It still pulls from source.

There's an example of how this can be done here:

https://github.com/nrwl/nx-incremental/blob/master/tools/scripts/watch.js
https://github.com/nrwl/nx-incremental/blob/master/apps/ngapp/tsconfig.app.json

We're still working on how we can make this a generic solution.

@FrozenPandaz FrozenPandaz reopened this Aug 21, 2020
@FrozenPandaz FrozenPandaz added the scope: core core nx functionality label Aug 21, 2020
@gperdomor
Copy link
Contributor

@FrozenPandaz any progress? I hope we can run nx serve app --with-deps soon 🙏

@github-actions
Copy link

This issue has been automatically marked as stale because it hasn't had any recent activity. It will be closed in 14 days if no further activity occurs.
If we missed this issue please reply to keep it active.
Thanks for being a part of the Nx community! 🙏

@github-actions github-actions bot added the stale label Jan 11, 2021
@maxime1992
Copy link
Author

Based on the comment

We're still working on how we can make this a generic solution.

I believe this should stay open (for the bot..)

@github-actions github-actions bot removed the stale label Jan 12, 2021
@jhesgodi
Copy link

jhesgodi commented Feb 5, 2021

thanks @maxime1992. for anyone new to this issue, I've made my own local plugin to deal with buildable libraries based on #3501 (comment) answer

https://gist.github.com/jhesgodi/2d530753c551ace665a8c3010d3a719c

@github-actions
Copy link

This issue has been automatically marked as stale because it hasn't had any recent activity. It will be closed in 14 days if no further activity occurs.
If we missed this issue please reply to keep it active.
Thanks for being a part of the Nx community! 🙏

@github-actions github-actions bot added the stale label Mar 22, 2021
@maxime1992
Copy link
Author

up (bot)

@github-actions github-actions bot removed the stale label Mar 22, 2021
@github-actions
Copy link

github-actions bot commented May 7, 2021

This issue has been automatically marked as stale because it hasn't had any recent activity. It will be closed in 14 days if no further activity occurs.
If we missed this issue please reply to keep it active.
Thanks for being a part of the Nx community! 🙏

@github-actions github-actions bot added the stale label May 7, 2021
@maxime1992
Copy link
Author

Up

@github-actions github-actions bot removed the stale label May 18, 2021
@ianldgs
Copy link
Contributor

ianldgs commented May 28, 2021

FYI:

Currently, serve does not really use buildable library computation. It still pulls from source.

This might not be true anymore.
Based on some tests I made, the serve command would fail if one of my libraries wasn't built, but will work if I manually build it.

@github-actions
Copy link

This issue has been automatically marked as stale because it hasn't had any recent activity. It will be closed in 14 days if no further activity occurs.
If we missed this issue please reply to keep it active.
Thanks for being a part of the Nx community! 🙏

@github-actions
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants