-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Target dependencies can be passed invalid parameters when dependency is a different task #9100
Comments
Looks like something I am proposing here: #9034 in "Alternate Implementations". |
There are definitely some changes that should be made to loosen up targetDependencies, in case a target doesn't exist on a dependency or params are invalid on the dep. |
I think this may be at least mostly resolved by the new dependsOn configuration where you can specify what to do with params? It doesn't provide any fine-grained control, but that may be a separate issue |
This issue has been automatically marked as stale because it hasn't had any recent activity. It will be closed in 14 days if no further activity occurs. |
This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context. |
Current Behavior
I currently have a core-based setup where I have my tsconfig for Jest including only the jest files, with a project reference pointing to the build tsconfig, so that it references the built files of my app. I have linter rules enabled that require type checking, and this means that I get lint errors if my main app is not built when I go to do a lint (which includes the test files). However, if I pass any parameters to my lint task, they also get passed to my build job - and my built job is
tsc
, which complains about invalid parameters.Admittedly, I'm not sure that I like this tsconfig setup anyways, but there may still be other instances where this could prove to be problematic.
Expected Behavior
There should be some sort of control for determining whether any/some/all of the parameters passed to a task are passed to that task's dependencies, namely when the dependencies are a different type of task (though even if it's the same task it may still be relevant, as for example different built tasks may use different commands).
Environment
The text was updated successfully, but these errors were encountered: