feat(core): merge more target options from targetDefaults

[AgentEnder]

Current Behavior

Target defaults may only contain dependsOn, inputs, outputs etc and can only be applied based on the name of the target.

New Behavior

Target defaults may contain any property inside TargetConfiguration, and can be applied based on targetName, executorName, or both.

Keys in the mapping can be any of the following:

• `${executor}`
• `${targetName}`

A # symbol is used as a separator between targetName and executorName. This is analogous to how we can specify an export in a module when writing a generator's implementation path. build#nx:run-commands would indicate any target named build that uses nx:run-commands as the executor.

When merging defaults, options are merged 1 layer deep. Additionally, {projectRoot} and {workspaceRoot} are valid within targetDefaults. As an example, merging the defaults

{
  path: "{workspaceRoot}/{projectRoot}
  other: "hello"
  optimization: {
    "a": true
  }
}

with the provided options:

{
  optimization: {
    "b": true
  }
}

would result in:

{
  path: "libs/my-lib"
  other: "hello"
  optimization: {
    "b": true
  }
}

Related Issue(s)

Fixes #12433

[nx-cloud-staging]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f797af7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 12 targets

• nx affected --target=e2e --base=14a3d6e364fa396bf58a0bdd08613112d83e2fad --head=f797af7d9e05a1b645d58ce840c408682d39d201 --exclude=e2e-storybook,e2e-storybook-angular,e2e-react-native,e2e-detox,e2e-make-angular-cli-faster --parallel=1
• nx affected --target=test --base=14a3d6e364fa396bf58a0bdd08613112d83e2fad --head=f797af7d9e05a1b645d58ce840c408682d39d201 --parallel=1
• nx affected --target=build --base=14a3d6e364fa396bf58a0bdd08613112d83e2fad --head=f797af7d9e05a1b645d58ce840c408682d39d201 --parallel=3
• nx affected --target=lint --base=14a3d6e364fa396bf58a0bdd08613112d83e2fad --head=f797af7d9e05a1b645d58ce840c408682d39d201 --parallel=3
• nx-cloud record -- yarn depcheck
• nx-cloud record -- yarn nx workspace-lint
• nx-cloud record -- yarn check-lock-files
• nx-cloud record -- yarn check-commit
• nx-cloud record -- yarn nx format:check --base=14a3d6e364fa396bf58a0bdd08613112d83e2fad --head=f797af7d9e05a1b645d58ce840c408682d39d201
• nx-cloud record -- yarn check-imports
• nx-cloud record -- yarn documentation
• nx build typedoc-theme

---

Sent with 💌 from NxCloud.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
nx-dev	✅ Ready (Inspect)	Visit Preview	Dec 29, 2022 at 10:50PM (UTC)

[minijus]

Nice! This will allow to set executor defaults as suggested in rather old discussion: #8544 (comment)

[luxaritas]

Does this also wind up finishing resolution of #9100? Or is there liable to be further work there?

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit d056d03. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 11 targets

• nx affected --target=e2e --base=66a26583da75dac275590e8de06455ad37da9f9a --head=d056d0328e77f0dd4e7e7d6cc4e55892878522c7 --exclude=e2e-storybook,e2e-storybook-angular,e2e-react-native,e2e-detox --parallel=1
• nx affected --target=test --base=66a26583da75dac275590e8de06455ad37da9f9a --head=d056d0328e77f0dd4e7e7d6cc4e55892878522c7 --parallel=1
• nx affected --target=build --base=66a26583da75dac275590e8de06455ad37da9f9a --head=d056d0328e77f0dd4e7e7d6cc4e55892878522c7 --parallel=3
• nx depcheck --no-dte
• nx affected --target=lint --base=66a26583da75dac275590e8de06455ad37da9f9a --head=d056d0328e77f0dd4e7e7d6cc4e55892878522c7 --parallel=3
• nx lint --no-dte
• nx check-lock-files --no-dte
• nx check-commit --no-dte
• nx-cloud record -- nx format:check --base=66a26583da75dac275590e8de06455ad37da9f9a --head=d056d0328e77f0dd4e7e7d6cc4e55892878522c7
• nx check-imports --no-dte
• nx documentation --no-dte

---

Sent with 💌 from NxCloud.

[vsavkin]

This is good. Some comments:

• The docs don't cover everything. We should update the Nx repo to use this feature, dog food it and then write a recipe. Can you create tasks for it?
• I think your code can be clearer if you select better names. It's kind of hard to parse cause names appear somewhat random.

[AgentEnder]

The docs don't cover everything. We should update the Nx repo to use this feature, dog food it and then write a recipe. Can you create tasks for it?

Yeah, I'll make them :)

I think your code can be clearer if you select better names. It's kind of hard to parse cause names appear somewhat random.

This is a fair criticism, I'm especially bad about this when writing tests. I'll correct the naming as pointed out. Thanks Victor!

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.