fix(js): .swcrc path should be customizable #10118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
AgentEnder
requested changes
May 3, 2022
packages/js/src/utils/schema.d.ts
Outdated
| @@ -35,6 +35,7 @@ export interface ExecutorOptions { | |||
| main: string; | |||
| outputPath: string; | |||
| tsConfig: string; | |||
| swcrcPath?: string; | |||
There was a problem hiding this comment.
This prop should be required since it has a default value, and the function would not work correctly if its null.
There was a problem hiding this comment.
Gotcha! I've pushed the change. Unit tests pass locally without any changes. I didn't mange to get E2E tests running on main and couldn't find any coverage for this codepath so I'll just see if the tests pass on CI.
AgentEnder
changed the title
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
It is currently not possible to provide a custom path to an swcrc path. Instead, JS projects using SWC must have a
.lib.swcrcfile in the project root directory.Expected Behavior
With these changes, the
@nrwl/js:swcexecutor can optionally be be passed answcrcPath.In
project.json:{ "targets": { "build": { "executor": "@nrwl/js:swc", "options": { ... "swcrcPath": "path/to/swcrc" } } } }Related Issue(s)
Fixes #10058