Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(testing): support jest 28 #10857

Merged
merged 22 commits into from Aug 18, 2022
Merged

feat(testing): support jest 28 #10857

merged 22 commits into from Aug 18, 2022

Conversation

barbados-clemens
Copy link
Contributor

Current Behavior

does not support jest 28

Expected Behavior

support jest 28

Related Issue(s)

Fixes #10117

@nx-cloud
Copy link

nx-cloud bot commented Jun 22, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2daaa91. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


🟥 Failed Commands
nx affected --target=e2e --base=8e22de4d47e9c316963324a5fc00308c9a0e1a65 --head=2daaa917b15f9c2c4ded71c9f93a1f410b7fc83c --exclude=e2e-storybook,e2e-storybook-angular,e2e-react-native,e2e-detox,e2e-make-angular-cli-faster --parallel=1
✅ Successfully ran 11 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Jun 22, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Aug 18, 2022 at 9:52PM (UTC)

@johannesschobel
Copy link
Contributor

any ETA on this?

@barbados-clemens
Copy link
Contributor Author

Hi @johannesschobel plan is to get this finished this week.

@barbados-clemens barbados-clemens enabled auto-merge (squash) August 18, 2022 22:15
@FrozenPandaz FrozenPandaz merged commit 657b2bf into master Aug 18, 2022
@FrozenPandaz FrozenPandaz deleted the jest-28 branch August 18, 2022 22:40
@jaytavares
Copy link
Contributor

@FrozenPandaz I'm a little confused. I see this PR is merged and I see that there has been an Nx release published since this merge; however, when I run nx migrate latest and nx migrate --run-migrations my jest version stays at 27. Shouldn't it be getting bumped to v28 now?

@rique-dev
Copy link

rique-dev commented Aug 23, 2022

Same here. I also tried to migrate to 14.6.0-beta.0 or 14.6.0-beta, but persist at 27.

@rique-dev
Copy link

@jaytavares I found solution. You can try nx migrate 14.6.0-beta.7

@barbados-clemens
Copy link
Contributor Author

@jaytavares @rique-dev this change is included in v14.6.0 which is in beta right now. if you want to migrate to the beta version you have to use the next tag not latest.

if you want to jump to the beta you can use.
nx migrate @nrwl/jest@next --from @nrwl/jest@14.5.0

if you were already on a beta then it probably didn't get bumped correctly since the PR targeted an earlier beta that was already released.

@rique-dev
Copy link

@barbados-clemens Awesome! Thx!

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't run tests with jest 28.0
7 participants