Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat(core): support reading cli args from env" #11738

Merged
merged 1 commit into from
Aug 26, 2022

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Aug 26, 2022

Since we use NX_ environment variables it is causing issues when additionalProperties: false is used in our schemas. Running a command can fail if the converted option is not in schema.

@vercel
Copy link

vercel bot commented Aug 26, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Aug 26, 2022 at 4:12PM (UTC)

@jaysoo jaysoo merged commit ef5334b into master Aug 26, 2022
@jaysoo jaysoo deleted the revert-11721-tknickman/nx-11713 branch August 26, 2022 16:17
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant