Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add yarn lock file pruning #12105

Merged
merged 20 commits into from
Sep 21, 2022
Merged

Conversation

meeroslav
Copy link
Contributor

@meeroslav meeroslav commented Sep 19, 2022

This PR depends on #11953 and should not be merged first

  • Prune Yarn Classic
  • Prune Yarn Berry
  • Prune Npm
  • Prune Pnpm (w/ + w/o inline specifiers)
  • Prune Pnpm meta information (optional, patches etc.)

Current Behavior

Expected Behavior

Related Issue(s)

Related to #9761

@meeroslav meeroslav self-assigned this Sep 19, 2022
@vercel
Copy link

vercel bot commented Sep 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Sep 21, 2022 at 3:05PM (UTC)

import { satisfies } from 'semver';
import { sortObject } from './utils';

export type YarnLockFile = Record<
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should not be exported

Omit<PackageDependency, 'packageMeta'>
>;

export type YarnBerryLockFile = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should not be exported

import { readFileSync, writeFileSync } from 'fs-extra';
import { detectPackageManager, PackageManager } from '../package-manager';
import {
parseLockFile as parseYarn,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should rename thing. We should just name it parseYarnLockFile

@meeroslav meeroslav enabled auto-merge (squash) September 21, 2022 15:03
@meeroslav meeroslav merged commit bd7a266 into nrwl:master Sep 21, 2022
@meeroslav meeroslav deleted the prune-lock-file branch November 8, 2022 15:34
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: core core nx functionality type: feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants