-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(react): load svg component in buildable library #12226
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
e24aa69
to
a7602e4
Compare
a7602e4
to
8317dde
Compare
8317dde
to
e9a93a1
Compare
Hey, is there anything I can do to advance this pull request? |
e9a93a1
to
e6f7abf
Compare
Any updates when this could be merged? I am seeing this problem with the latest nx version as well |
e6f7abf
to
a04bb83
Compare
any updates on this, please? it's a real problem |
a04bb83
to
e212902
Compare
5351189
to
6cfc370
Compare
added svg and url loaders to rollup config of buildabel react library, like in webpack for react app. ISSUES CLOSED: nrwl#6761
6cfc370
to
63761a5
Compare
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Added svg and url loaders to rollup config of buildable react library, like in webpack config for react app (packages/react/plugins/webpack.ts).
Current Behavior
A new library with
nx g @nrwl/react:lib
which tries to import svg files fails with the error belowError during bundle: Error: 'ReactComponent' is not exported by <path/to/svg>
Expected Behavior
Build should be sucessful
Related Issue(s)
Fixes #6761