Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): fix root selector in index.html for standalone remotes #12255

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Sep 27, 2022

Current Behavior

When generating a standalone remote we delete the unneeded app component but do not change the root selector in the index.html

Expected Behavior

make sure to change the root selector being used

@Coly010 Coly010 self-assigned this Sep 27, 2022
@vercel
Copy link

vercel bot commented Sep 27, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Sep 27, 2022 at 9:01AM (UTC)

@Coly010 Coly010 merged commit 66d1aed into nrwl:master Sep 27, 2022
@Coly010 Coly010 deleted the angular/fix-standalone-remote-root branch September 27, 2022 09:21
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant