feat(core): add glob support for project-level implicit dependencies

[AgentEnder]

Current Behavior

There is no way to specify all other projects as an implicit dependency of project {x}.

Expected Behavior

You can specify "*" in implicit dependencies to specify all other projects as a dependency. This is especially useful in the case of the root project, which may depend on all other projects.

Additionally, if you wanted to specify all other projects, except {x} as a dependency of {y}, then in {y}'s project configuration you could specify:

implicitDependencies: ['*', '!x']

Related Issue(s)

Fixes #

[nx-cloud-staging]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b9ed938. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

🟥 Failed Commands
nx affected --target=e2e --base=c18ec6ccd698334c3af2d13410256f2aacfbcc55 --head=b9ed9382ca9fdfb0032c790136b1489b6c8e4b8d --exclude=e2e-storybook,e2e-storybook-angular,e2e-react-native,e2e-detox --parallel=1

✅ Successfully ran 11 targets

• nx affected --target=test --base=c18ec6ccd698334c3af2d13410256f2aacfbcc55 --head=b9ed9382ca9fdfb0032c790136b1489b6c8e4b8d --parallel=1
• nx affected --target=build --base=c18ec6ccd698334c3af2d13410256f2aacfbcc55 --head=b9ed9382ca9fdfb0032c790136b1489b6c8e4b8d --parallel=3
• nx affected --target=lint --base=c18ec6ccd698334c3af2d13410256f2aacfbcc55 --head=b9ed9382ca9fdfb0032c790136b1489b6c8e4b8d --parallel=3
• nx-cloud record -- yarn depcheck
• nx-cloud record -- yarn nx workspace-lint
• nx-cloud record -- yarn check-lock-files
• nx-cloud record -- yarn check-commit
• nx-cloud record -- yarn nx format:check --base=c18ec6ccd698334c3af2d13410256f2aacfbcc55 --head=b9ed9382ca9fdfb0032c790136b1489b6c8e4b8d
• nx-cloud record -- yarn check-imports
• nx-cloud record -- yarn documentation
• nx build typedoc-theme

---

Sent with 💌 from NxCloud.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
nx-dev	✅ Ready (Inspect)	Visit Preview	Dec 29, 2022 at 10:39PM (UTC)

[vsavkin]

We should mention this in the docs

[FrozenPandaz]

Let's talk offline about this.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8ec97e3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 11 targets

• nx affected --target=test --base=4a43a04caf725cdb10dcc11fd0480c5f49430523 --head=8ec97e313c4ca3702593bcad1ef3ad978b15dd04 --parallel=1
• nx depcheck --no-dte
• nx affected --target=e2e --base=4a43a04caf725cdb10dcc11fd0480c5f49430523 --head=8ec97e313c4ca3702593bcad1ef3ad978b15dd04 --exclude=e2e-storybook,e2e-storybook-angular,e2e-react-native,e2e-detox --parallel=1
• nx lint --no-dte
• nx check-lock-files --no-dte
• nx affected --target=lint --base=4a43a04caf725cdb10dcc11fd0480c5f49430523 --head=8ec97e313c4ca3702593bcad1ef3ad978b15dd04 --parallel=3
• nx check-commit --no-dte
• nx affected --target=build --base=4a43a04caf725cdb10dcc11fd0480c5f49430523 --head=8ec97e313c4ca3702593bcad1ef3ad978b15dd04 --parallel=3
• nx-cloud record -- nx format:check --base=4a43a04caf725cdb10dcc11fd0480c5f49430523 --head=8ec97e313c4ca3702593bcad1ef3ad978b15dd04
• nx check-imports --no-dte
• nx documentation --no-dte

---

Sent with 💌 from NxCloud.

[vsavkin]

since you extracted this into a separate utility which is used in more than place, you can add some tests for this utility

[AgentEnder]

Yeah, thats a good shout out. I'll get them added.

[vsavkin]

we should rewrite this function. Currently the normalization of implicit dependencies is O(N^2), where N is the number of projects. In the worst case scenario it will be O(N^2) if say every project depends on every other project via '*', but his worst case scenario is unlikely.

What I would do is:

• Check if implicitDependencies is empty and skip the whole thing altogether.
• Check if there are some implicitDependencies using say '*', and if not, just assign them as project names.
• And only if there are implicitDeps that have special characters, I'd filter our the source and do the matching.

[AgentEnder]

Sure, I can add some of the short-circuiting logic.

[AgentEnder]

I'm pushing up the changes here now. To summarize, this is the approach I took:

• Updated findMatchingProjects to short circuit if the nameOrPattern doesn't contain special characters. In this case, it will add it if its a valid project, and skip the glob matching entirely regardless.
• If implicit dependencies is null or an empty array, we don't call into findMatchingProjects at all and simply return an empty array.
• We pass in the list of projectNames to normalizeImplicitDependencies. This should be the biggest boost in perf compared to the last pass at this. Now we find any matching projects, and then filter the source project out of the matches. This should mean filtering a much smaller array for large workspaces.

Stale

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.