Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): support nested projects when deriving the project name from a given path #13349

Conversation

leosvelperez
Copy link
Member

Current Behavior

The getProjectNameFromDirPath utility to derive a project name from a given path doesn't support a workspace with a project at the root and/or nested projects. This causes things like the Tailwind CSS utility to get the glob patterns for a project's dependencies (used by the Angular and React plugins) to fail and not return any glob pattern.

Expected Behavior

The getProjectNameFromDirPath utility to derive a project name from a given path supports a workspace with a project at the root and/or nested projects.

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this Nov 23, 2022
@vercel
Copy link

vercel bot commented Nov 23, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Nov 23, 2022 at 11:20AM (UTC)

@FrozenPandaz
Copy link
Collaborator

Closed by #13364

@leosvelperez leosvelperez deleted the core/find-root-nested-project-by-path branch January 25, 2023 13:05
@github-actions
Copy link

github-actions bot commented Mar 7, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants