-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(core): reconcile functions to find project of a path #13364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
f9444dd
to
21cd53a
Compare
21cd53a
to
b94df3f
Compare
b94df3f
to
6dc79a9
Compare
e20c6a5
to
c502e9e
Compare
c502e9e
to
18026ed
Compare
18026ed
to
0957979
Compare
0957979
to
6d768ba
Compare
6d768ba
to
7cae039
Compare
7cae039
to
e60944a
Compare
e60944a
to
43f0b7e
Compare
43f0b7e
to
cdafca6
Compare
cdafca6
to
5cfa987
Compare
…ator (nrwl#13268)" This reverts commit bd4f4a2.
This reverts commit de44bf8.
)" This reverts commit ab6f62a.
5cfa987
to
6cfde0b
Compare
The |
Reviewed with @AgentEnder @vsavkin @meeroslav |
This was referenced Nov 24, 2022
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
There are 4-5 different implementations of finding which project a file belongs to.
Expected Behavior
There are 2 different implementations of finding which project a file belongs to:
createProjectRootMapping(graph.nodes)
createProjectRootMappingsFromProjectConfigurations({ [name]: ProjectConfiguration)
findProjectForPath(path, mapping)
Related Issue(s)
Fixes #