Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): additional null check when hashing lockfile #13803

Merged
merged 1 commit into from
Dec 14, 2022
Merged

fix(core): additional null check when hashing lockfile #13803

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 18 additions & 8 deletions packages/nx/src/lock-file/utils/hashing.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,29 +34,39 @@ function hashExternalNode(node: ProjectGraphExternalNode, graph: ProjectGraph) {
if (!graph.dependencies[node.name]) {
node.data.hash = hashString(hashKey);
} else {
const hashingInput = [hashKey];

// collect all dependencies' hashes
traverseExternalNodesDependencies(node.name, graph, hashingInput);
node.data.hash = defaultHashing.hashArray(hashingInput.sort());
const externalDependencies = traverseExternalNodesDependencies(
node.name,
graph,
new Set([hashKey])
);
node.data.hash = defaultHashing.hashArray(
Array.from(externalDependencies).sort()
);
}
}

function traverseExternalNodesDependencies(
projectName: string,
graph: ProjectGraph,
visited: string[]
) {
visited: Set<string>
): Set<string> {
graph.dependencies[projectName].forEach((d) => {
const target = graph.externalNodes[d.target];
if (!target) {
return;
}

const targetKey = `${target.data.packageName}@${target.data.version}`;
if (visited.indexOf(targetKey) === -1) {
visited.push(targetKey);

if (!visited.has(targetKey)) {
visited.add(targetKey);
if (graph.dependencies[d.target]) {
traverseExternalNodesDependencies(d.target, graph, visited);
}
}
});
return visited;
}

/**
Expand Down