Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(angular): support alternate remoteEntry name in dynamic federation #13688 #13899

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Dec 19, 2022

Current Behavior

Dynamic federation can encounter issues with webpack caching with the same file name used across remotes.

Expected Behavior

Allow the name to be configurable by setting it within the module-federation.manifest.json

Related Issue(s)

Fixes #13688

@Coly010 Coly010 self-assigned this Dec 19, 2022
@vercel
Copy link

vercel bot commented Dec 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Dec 20, 2022 at 9:29AM (UTC)

Co-authored-by: Leosvel Pérez Espinosa <leosvel.perez.espinosa@gmail.com>
Copy link
Member

@leosvelperez leosvelperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Coly010 Coly010 merged commit e53303b into nrwl:master Dec 20, 2022
@Coly010 Coly010 deleted the angular/13688-support-alt-remoteEntry-in-dynamic-fed branch December 20, 2022 09:56
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Angular] [Module Federation] Make remoteEntry filename configurable
2 participants