Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(angular): support alternate remoteEntry name in dynamic federation #13688 #13899

Merged
merged 2 commits into from
Dec 20, 2022
Merged

feat(angular): support alternate remoteEntry name in dynamic federation #13688 #13899

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e244181
feat(angular): support alternate remoteEntry name in dynamic federati…
Coly010 Dec 19, 2022
7f6f5d8
fix(angular): simplify dyn fed url creation
Coly010 Dec 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 6 additions & 3 deletions packages/angular/mf/mf.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,12 @@ async function loadRemoteContainer(remoteName: string) {
? remoteUrlDefinitions[remoteName]
: await resolveRemoteUrl(remoteName);

const containerUrl = `${remoteUrl}${
remoteUrl.endsWith('/') ? '' : '/'
}remoteEntry.mjs`;
let containerUrl = remoteUrl;
if (!remoteUrl.endsWith('.mjs') && !remoteUrl.endsWith('.js')) {
containerUrl = `${remoteUrl}${
remoteUrl.endsWith('/') ? '' : '/'
}remoteEntry.mjs`;
}

const container = await loadModule(containerUrl);
await container.init(__webpack_share_scopes__.default);
Expand Down