Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): revert change to use new lockfile utils #13962

merged 1 commit into from Dec 21, 2022


Copy link

Current Behavior

The changes in this commit add a ton of extra dependencies to published packages even though there is a flag which asks not to alter the package.json.

This caused issues in our own e2e tests as @nrwl/* packages had a lot of additional dependencies:


Expected Behavior

This reverts the changes to @nrwl/js:tsc made in the above commit and restores the package.json behavior during @nrwl/js:tsc

Related Issue(s)

Fixes #

Copy link

vercel bot commented Dec 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Dec 21, 2022 at 8:20PM (UTC)

@FrozenPandaz FrozenPandaz marked this pull request as ready for review December 21, 2022 20:49
Copy link
Collaborator Author

Failures are unrelated to this change.

@FrozenPandaz FrozenPandaz enabled auto-merge (squash) December 21, 2022 20:49
@FrozenPandaz FrozenPandaz merged commit 84cc1c1 into nrwl:master Dec 21, 2022
11 of 13 checks passed
@FrozenPandaz FrozenPandaz deleted the fix-js-exec branch December 21, 2022 20:50
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants