Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(core): fix links to devkit index page #14034

Merged
merged 4 commits into from
Jan 4, 2023
Merged

Conversation

felipeplets
Copy link
Contributor

Current Behavior

Documentation link on the sidebar menu to the DevKit package is broken.

Expected Behavior

Documentation link is fixed.

Related Issue(s)

Fixes #14033

@vercel
Copy link

vercel bot commented Dec 27, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Jan 4, 2023 at 6:37PM (UTC)

@bcabanes bcabanes changed the title docs: fix links to devkit index page docs(core): fix links to devkit index page Jan 3, 2023
Copy link
Member

@bcabanes bcabanes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the time and the contribution, I only have a minor change and it should be good to go 👍

docs/map.json Outdated Show resolved Hide resolved
Co-authored-by: Benjamin Cabanes <3447705+bcabanes@users.noreply.github.com>
@felipeplets
Copy link
Contributor Author

Thank you for the time and the contribution, I only have a minor change and it should be good to go 👍

Done. Thank you for the review @bcabanes

@bcabanes
Copy link
Member

bcabanes commented Jan 3, 2023

You will have to run yarn documentation again and commit the files to make the CI pass and propagate the changes to the generated documentation.

Fixed links on the documentation to correctly point to the entry point for the DevKit documentation.

ISSUES CLOSED: nrwl#14033
@felipeplets
Copy link
Contributor Author

@bcabanes done.

Copy link
Member

@bcabanes bcabanes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect thank you!

@bcabanes bcabanes merged commit 2e8511a into nrwl:master Jan 4, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't reach the devkit page from the docs side bar
2 participants