-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(webpack): sourceMap option must be a boolean if/when passed to loaders #14622
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
sourceMap: options.sourceMap, | ||
sourceMap: !!options.sourceMap, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This solution is already being used below
nx/packages/webpack/src/utils/with-web.ts
Line 424 in c134efe
sourceMap: !!options.sourceMap, |
f9f96be
to
8952b27
Compare
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
When using
sourceMap: 'hidden'
as an nx webpack config option you see errors from loaderseg.
Expected Behavior
No errors when specifying
'hidden'
as thesourceMap
config.Note, all modified loader configs expect a boolean: