feat(angular): add routing option to CNW #14845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coly010
requested review from
FrozenPandaz,
AgentEnder and
vsavkin
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Coly010
force-pushed
the
angular/add-router-prompt
branch
from
54c775a
to
1a3b3a7
Compare
Coly010
force-pushed
the
angular/add-router-prompt
branch
from
1a3b3a7
to
5fdf545
Compare
bcabanes
approved these changes
Feb 8, 2023
AgentEnder
approved these changes
Feb 9, 2023
Coly010
force-pushed
the
angular/add-router-prompt
branch
from
5fdf545
to
e50c0ef
Compare
Coly010
requested review from
meeroslav,
barbados-clemens and
JamesHenry
as code owners
barbados-clemens
approved these changes
Feb 9, 2023
Coly010
force-pushed
the
angular/add-router-prompt
branch
from
e50c0ef
to
efcd906
Compare
FrozenPandaz
approved these changes
Feb 10, 2023
Coly010
force-pushed
the
angular/add-router-prompt
branch
from
efcd906
to
a2dd9f0
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
We don't ask on create workspace if someone would like to add routing to their app
Expected Behavior
To mimic behaviour of the angular cli, to be a full replacement, we should ask this question