feat(core): add standalone api prompt to CNW #14886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coly010
requested review from
FrozenPandaz,
vsavkin,
AgentEnder,
jaysoo and
bcabanes
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Coly010
force-pushed
the
angular/add-standalone-prompt
branch
from
636fcbe
to
d30658a
Compare
Coly010
force-pushed
the
angular/add-standalone-prompt
branch
from
d30658a
to
c697587
Compare
bcabanes
approved these changes
Feb 9, 2023
AgentEnder
approved these changes
Feb 9, 2023
Coly010
force-pushed
the
angular/add-standalone-prompt
branch
from
c697587
to
63bb705
Compare
Coly010
requested review from
meeroslav,
barbados-clemens and
JamesHenry
as code owners
Coly010
force-pushed
the
angular/add-standalone-prompt
branch
from
63bb705
to
56689bc
Compare
barbados-clemens
approved these changes
Feb 10, 2023
FrozenPandaz
approved these changes
Feb 10, 2023
| .prompt([ | ||
| { | ||
| name: 'standaloneApi', | ||
| message: 'Would you like to use Standalone APIs in your application?', |
There was a problem hiding this comment.
Suggested change
| message: 'Would you like to use Standalone APIs in your application?', | |
| message: 'Would you like to use Standalone Components?', |
Coly010
commented
Feb 10, 2023
| .prompt([ | ||
| { | ||
| name: 'standaloneApi', | ||
| message: 'Would you like to use Standalone APIs in your application?', |
There was a problem hiding this comment.
Would you like to use Standalone Components in your application?
Coly010
force-pushed
the
angular/add-standalone-prompt
branch
from
56689bc
to
060da09
Compare
FrozenPandaz
approved these changes
Feb 10, 2023
| @@ -56,6 +56,11 @@ | |||
| ] | |||
| } | |||
| }, | |||
| "standaloneApi": { | |||
| "description": "Use the Standalone APIs if generating an Angular application.", | |||
There was a problem hiding this comment.
This one should change too. Can you fix it in a follow up PR?
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
We do not ask if the user would like to use Standalone APIs when generating an Angular application with CNW
Expected Behavior
Angular are soon going to be changing their docs to prioritise Standalone Components + APIs and we already support generating an app with them.
We should ask users if they'd like to use them when generating an application along with a new workspace