Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(misc): make ts 4.8 update optional and add missing angular requirements #14918

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

leosvelperez
Copy link
Member

Current Behavior

Migrating to latest and skipping the Angular v15 update, results in a wrong setup with TS ~4.8.2 being installed which is not supported by Angular v14.
Migrating to latest when skipping the Angular v14.1 update we still get asked whether we want to update to Angular v15.
Migrating to latest when skipping the Angular v14.1 still installs Angular v14.1.1 (a required update for v14.1, but if v14.1 is not applied it shouldn't be applied either).

Expected Behavior

Users should be able to opt out of TS v4.8 update to allow using latest Nx with Angular v14.
If Angular v14.1 update is skipped, we shouldn't get asked whether we want to update to Angular v15.
Should only apply Angular v14.1.1 if v14.1 is applied.

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Feb 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 10, 2023 at 3:16PM (UTC)

@leosvelperez leosvelperez self-assigned this Feb 10, 2023
@FrozenPandaz FrozenPandaz merged commit 005eb56 into nrwl:master Feb 10, 2023
@leosvelperez leosvelperez deleted the misc/optional-ts-4.8-update branch February 10, 2023 19:51
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants