Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): remove plugins from esbuild will be done as a feature #14997

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

ndcunningham
Copy link
Contributor

Remove the plugins feature since it doesn't fully conform to esbuild API for plugins: https://esbuild.github.io/plugins/#using-plugins

This will be done as a feature, I will post the issue after it is created so that it is linked.
closed #14823

@vercel
Copy link

vercel bot commented Feb 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
nx-dev ⬜️ Ignored (Inspect) Feb 14, 2023 at 8:53PM (UTC)

@nx-cloud
Copy link

nx-cloud bot commented Feb 14, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 197065a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@AgentEnder AgentEnder merged commit ba19dc0 into nrwl:master Feb 14, 2023
FrozenPandaz pushed a commit that referenced this pull request Feb 15, 2023
@ndcunningham ndcunningham deleted the fix/issue-14823 branch February 16, 2023 17:20
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@nrwl/esbuild doesn't support plugins in esbuildOptions
3 participants