Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): write config correctly when using the angular cli adapter #15133

Merged

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Feb 20, 2023

Current Behavior

Running an Angular CLI schematic that updates project configuration only applies changes to the config if a new target is added. No other change to the config is flushed.

Expected Behavior

The changes made by an Angular CLI schematic updating project configuration should be applied correctly.

Related Issue(s)

Fixes #15014

@leosvelperez leosvelperez self-assigned this Feb 20, 2023
@vercel
Copy link

vercel bot commented Feb 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 21, 2023 at 3:50PM (UTC)

@leosvelperez leosvelperez merged commit 61e28c6 into nrwl:master Feb 21, 2023
@leosvelperez leosvelperez deleted the angular/ngcli-adapter-fix-write-config branch February 21, 2023 17:31
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nx Migration fails for a custom migration of a package
2 participants