feat(nx-plugin): add lint option for the e2e generator #15140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitry-stepanenko
requested review from
AgentEnder and
FrozenPandaz
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 52bf652. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
AgentEnder
approved these changes
Feb 20, 2023
| @@ -28,7 +28,7 @@ describe('NxPlugin e2e-project Generator', () => { | |||
| pluginOutputPath: `dist/libs/my-plugin`, | |||
| npmPackageName: '@proj/my-plugin', | |||
| }) | |||
| ).resolves.not.toThrow(); | |||
| ).resolves.toBeDefined(); | |||
There was a problem hiding this comment.
this is a bit weird, but not.toThrow() syntax starts to fail when generator returns Promise<GeneratorCallback>
dmitry-stepanenko
force-pushed
the
ds/nx-plugin-e2e-lint
branch
from
21cfbf7
to
f9e74a1
Compare
dmitry-stepanenko
force-pushed
the
ds/nx-plugin-e2e-lint
branch
from
f9e74a1
to
52bf652
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
e2e project for nx plugin is being generated without e2e target
Expected Behavior
Should have the lint target in the plugin's e2e project.
Related Issue(s)
Fixes #