fix(angular): give informative log when @Component styleUrls names …

[jonhamm]

this will show the path of the file that cannot be located unfortunately I was not able to log the name of the file with the styleUrls that specified the non-existing file

it is still an improvement as prior to this change the only feedback from the build would be this generic message: Cannot read properties of undefined (reading 'includes')

closed #15185

Current Behavior

when some styleUrls property of @Component specifies a path to a non-existing file
then when you run nx build on the library with this component the build fails with this error message:

Cannot read properties of undefined (reading 'includes')

Expected Behavior

the error message of the failing build will be like this:

Cannot read file /Users/xxx/work/git/wt/release/3.20/libs/some-librarysrc/lib/Stylex/some-file.scss.

Related Issue(s)

Fixes #15185

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated
nx-dev	⬜️ Ignored (Inspect)			Feb 24, 2023 at 5:46AM (UTC)

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 3339ea9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 8 targets

• nx run-many -t e2e-macos --parallel=1 --exclude=e2e-detox
• nx affected --target=e2e --base=e91e2c5b93ddfb53dca1901097d1e948fb6d1c6e --head=3339ea9e5fc1907b830103bdad66d11fd6b1cc52 --exclude=e2e-storybook,e2e-storybook-angular --parallel=1
• nx affected --target=test --base=e91e2c5b93ddfb53dca1901097d1e948fb6d1c6e --head=3339ea9e5fc1907b830103bdad66d11fd6b1cc52 --parallel=1
• nx run-many -t root-lint check-imports check-commit check-lock-files depcheck --parallel=1 --no-dte
• nx affected --target=build --base=e91e2c5b93ddfb53dca1901097d1e948fb6d1c6e --head=3339ea9e5fc1907b830103bdad66d11fd6b1cc52 --parallel=3
• nx affected --target=lint --base=e91e2c5b93ddfb53dca1901097d1e948fb6d1c6e --head=3339ea9e5fc1907b830103bdad66d11fd6b1cc52 --parallel=3
• nx-cloud record -- nx format:check --base=e91e2c5b93ddfb53dca1901097d1e948fb6d1c6e --head=3339ea9e5fc1907b830103bdad66d11fd6b1cc52
• nx documentation --no-dte

---

Sent with 💌 from NxCloud.

[leosvelperez]

hey @jonhamm! Thanks for the contribution!

Your fix is correct but the ng-packagr executors in Nx are a bit special. We try to keep them in sync as much as possible with the ng-packagr builder in the Angular CLI. This particular issue was already addressed on the builder and we missed it. While your solution is correct, it would deviate from what the builder has which would make harder future updates sync.

For that reason, I'll close this in favor of #15217 which follows the changes applied on the builder.

Once again, thanks for the contribution and keep up helping Nx be better!

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.