fix(core): shutdown the daemon when it is invalid #15550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
FrozenPandaz
force-pushed
the
daemon-kill
branch
4 times, most recently
from
e042000
to
a5e7759
Compare
FrozenPandaz
force-pushed
the
daemon-kill
branch
from
a5e7759
to
667049c
Compare
FrozenPandaz
force-pushed
the
daemon-kill
branch
from
667049c
to
fde6631
Compare
vsavkin
approved these changes
Mar 9, 2023
FrozenPandaz
force-pushed
the
daemon-kill
branch
from
fde6631
to
120fc8d
Compare
FrozenPandaz
force-pushed
the
daemon-kill
branch
from
120fc8d
to
835e6bb
Compare
FrozenPandaz
force-pushed
the
daemon-kill
branch
from
835e6bb
to
12b5510
Compare
FrozenPandaz
added a commit
that referenced
this pull request
Mar 10, 2023
(cherry picked from commit ad12ab2)
nartc
pushed a commit
to nartc/nx
that referenced
this pull request
Mar 13, 2023
meeroslav
pushed a commit
to meeroslav/nx
that referenced
this pull request
Mar 13, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
The daemon does not shut itself down when it is orphaned. This happens notably when
npm ciruns.Expected Behavior
The daemon shuts itself down when the
node_modules/.cache/nx/d/server-process.jsonis deleted or when the processId in there is different from the one running. This should ensure that only 1 daemon is running at a time. The daemon will also shutdown when it finds that the installed version of Nx has changed as that will also make it invalid.Related Issue(s)
Fixes #