fix(misc): shared deps that rely on default configuration are filtered out

[dmarcautan]

The issue was introduced by #15654. It then filters out and omits shared deps that rely on default configuration when return value from shared function is undefined.

Current Behavior

NPM package dependencies are not made shared in module federation configuration when are not explicitly excluded in user provided shared function by returning undefined value

Expected Behavior

NPM package dependencies should be made shared in module federation configuration unless shared function returns false value

Related Issue(s)

Fixes #15811

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
nx-dev	⬜️ Ignored (Inspect)			Apr 10, 2023 6:57am

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8ca24cb. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 8 targets

• nx affected -t e2e-macos --parallel=1 --exclude=e2e-detox
• nx affected --target=e2e --base=9690c0bb7c275ba93e682509ace0df683210743d --head=8ca24cbf1fcbde09797fda4da0650bc016a3c5e1 --parallel=1
• nx affected --target=test --base=9690c0bb7c275ba93e682509ace0df683210743d --head=8ca24cbf1fcbde09797fda4da0650bc016a3c5e1 --parallel=1
• nx run-many -t check-imports check-commit check-lock-files depcheck --parallel=1 --no-dte
• nx affected --target=build --base=9690c0bb7c275ba93e682509ace0df683210743d --head=8ca24cbf1fcbde09797fda4da0650bc016a3c5e1 --parallel=3
• nx affected --target=lint --base=9690c0bb7c275ba93e682509ace0df683210743d --head=8ca24cbf1fcbde09797fda4da0650bc016a3c5e1 --parallel=3
• nx-cloud record -- nx format:check --base=9690c0bb7c275ba93e682509ace0df683210743d --head=8ca24cbf1fcbde09797fda4da0650bc016a3c5e1
• nx documentation --no-dte

---

Sent with 💌 from NxCloud.

[leosvelperez]

Good catch!

Thanks for the contribution! 🎉

[barrymichaeldoyle]

Thank you so much for this one! I think this will solve my problem where I haven't been able to update my project beyond 15.8.6. Can't wait to test it out in the next release!

[barrymichaeldoyle]

Just tried out the beta and it seems to solve the issue! Thank you so much!

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.