fix(core): replace @nrwl with @nx in nx core packages #16344
Conversation
FrozenPandaz
requested review from
jaysoo,
xiongemi,
mandarini,
Coly010,
leosvelperez,
AgentEnder,
vsavkin,
meeroslav and
JamesHenry
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
| @@ -369,8 +369,8 @@ class TaskHasher { | |||
| // if it's "run commands" we skip traversing since we have no info what this command depends on | |||
| // for everything else we take the hash of the @nrwl package dependency tree | |||
| if ( | |||
| target.executor.startsWith(`@nrwl/`) && | |||
| target.executor !== `@nrwl/workspace:run-commands` | |||
There was a problem hiding this comment.
This always seemed wierd, do we no longer need it? I'd love a breakdown of what it was doing.
There was a problem hiding this comment.
Sure we can discuss this offline.
| (pluginName.startsWith('@nx/') || pluginName.startsWith('@nrwl/') | ||
| ? chalk.dim(` (v${nxVersion})`) | ||
| : ''), |
There was a problem hiding this comment.
Unrelated to the actual change - but does this report a bad version for labs packages like @nrwl/deno?
There was a problem hiding this comment.
Yes, I think it does.
There was a problem hiding this comment.
I agree - it also just flat out doesn't report a version for things like nx-dotnet. Here's a fix: #16353
It does unfortunately conflict with this PR - feel free to hold on merging it until after this one and I can fix it up.
FrozenPandaz
force-pushed
the
replace-nx
branch
6 times, most recently
from
1ab8933
to
8debd07
Compare
FrozenPandaz
force-pushed
the
replace-nx
branch
from
8debd07
to
0269a10
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
There are still some usages of
@nrwl/innx,@nx/devkit,create-nx-workspace, andcreate-nx-plugin.Expected Behavior
The usages of
@nrwl/ have been modified to support@nxinnx,@nx/devkit,create-nx-workspace, andcreate-nx-plugin`.Related Issue(s)
Fixes #