Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(core): rescope recipe #16403

Merged
merged 9 commits into from
Apr 27, 2023
Merged

docs(core): rescope recipe #16403

merged 9 commits into from
Apr 27, 2023

Conversation

isaacplmann
Copy link
Collaborator

  • Changes all references in the docs from @nrwl/ to @nx/
  • Adds a recipe explaining why the rescope happened and what people need to do
  • Adds a note in each of the plugin overview pages referencing the recipe

@vercel
Copy link

vercel bot commented Apr 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 27, 2023 9:49pm

@bcabanes bcabanes changed the title docs: nx scope docs(core): rescope recipe Apr 19, 2023
@isaacplmann
Copy link
Collaborator Author

@FrozenPandaz I'll fix these conflicts whenever we're close to the v16 release. Just let me know.

Copy link
Collaborator

@FrozenPandaz FrozenPandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I think this is now overboard after we've added the snippet footers. Can we remove these banners?

image

  1. For the @nx/devkit page, let's add a banner somehow?

  2. The @nx/eslint-plugin page has the wrong package name. The contents also have the wrong rule names. It is @nx/typescript instead of @nx/nx/typescript. This page as well.

  3. The @nx/plugin page also has issues

@github-actions
Copy link

github-actions bot commented May 3, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants