Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working link #16450

Closed
wants to merge 1 commit into from
Closed

Working link #16450

wants to merge 1 commit into from

Conversation

max-programming
Copy link

The link on the webpage isn't clickable. With this PR it is

image

@vercel
Copy link

vercel bot commented Apr 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 20, 2023 8:58pm

@nx-cloud
Copy link

nx-cloud bot commented Apr 20, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 105aa3f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


🟥 Failed Commands
nx documentation --no-dte
✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link
Member

@AgentEnder AgentEnder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to close this out since we unfortunately can't make this link clickable super easily.

Thanks for the contribution

@@ -5,7 +5,7 @@ description: 'Adds Nx to any type of workspace. It installs nx, creates an nx.js

# init

Adds Nx to any type of workspace. It installs nx, creates an nx.json configuration file and optionally sets up distributed caching. For more info, check https://nx.dev/recipes/adopting-nx.
Adds Nx to any type of workspace. It installs nx, creates an nx.json configuration file and optionally sets up distributed caching. For more info, check [https://nx.dev/recipes/adopting-nx](https://nx.dev/recipes/adopting-nx).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, a few things:

  • This is generated documentation, can't just change it here
  • This link shows up in the help text for nx init, and the text here is pulled from it. Markdown doesnt render in the terminal, so we can't use a markdown link here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it! Didn't know that it also appeared in the terminal that way ✌️

@AgentEnder AgentEnder closed this Apr 20, 2023
@max-programming max-programming deleted the patch-1 branch April 20, 2023 23:29
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants