Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(angular): deprecate ngrx generator #16953

Merged
merged 1 commit into from
May 11, 2023

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented May 11, 2023

Current Behavior

NgRx is deprecated since the addition of ngrx-root-store and ngrx-feature-store.
It is not marked as deprecated.

Expected Behavior

Mark it as deprecated.

On nx.dev, this will show as deprecated when visiting the actual generator's docs. Ben has a todo task to show a "Deprecated" badge on the plugin's generator list page.
When running the command, a warning is logged about it being deprecated.

Related Issue(s)

Fixes #

@Coly010 Coly010 self-assigned this May 11, 2023
@vercel
Copy link

vercel bot commented May 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2023 3:01pm

@Coly010 Coly010 merged commit d0c6f5d into nrwl:master May 11, 2023
@Coly010 Coly010 deleted the angular/deprecate-ngrx-generator branch May 11, 2023 15:21
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants