fix(core): projects within folders that start with a . should be found
#18748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Cammisuli
approved these changes
Aug 21, 2023
AgentEnder
force-pushed
the
fix/dotfile-projects-should-be-present
branch
from
eca71e6
to
287b694
Compare
AgentEnder
requested review from
FrozenPandaz,
jaysoo,
a team,
meeroslav,
vsavkin,
mandarini,
StalkAltan,
rarmatei and
JamesHenry
as code owners
AgentEnder
force-pushed
the
fix/dotfile-projects-should-be-present
branch
from
287b694
to
ed83a43
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
project.jsonfiles within a dot folder (e.g..github,.circlecietc) are ignored. This is a regression from behavior prior to Nx 16.6Expected Behavior
Files and projects within dot folders are matched by minimatch in Nx's core where applicable, including during project location
Related Issue(s)
Fixes #18692